You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2014/11/15 06:11:08 UTC
Review Request 28085: Fixed some coverity issues.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28085/
-----------------------------------------------------------
Review request for cloudstack and Kishan Kavala.
Repository: cloudstack-git
Description
-------
Fixed some coverity issues.
Added the prepared statement close statements.
https://issues.apache.org/jira/browse/CLOUDSTACK-7710
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java dab2b46a5759819951a0bf6b7d9f06df78b11e88
Diff: https://reviews.apache.org/r/28085/diff/
Testing
-------
Thanks,
bharat kumar
Re: Review Request 28085: Fixed some coverity issues.
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28085/#review79021
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On Nov. 15, 2014, 5:11 a.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28085/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2014, 5:11 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fixed some coverity issues.
>
> Added the prepared statement close statements.
> https://issues.apache.org/jira/browse/CLOUDSTACK-7710
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java dab2b46a5759819951a0bf6b7d9f06df78b11e88
>
> Diff: https://reviews.apache.org/r/28085/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>