[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

[GitBox <gi...@apache.org>]

tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR
URL: https://github.com/apache/incubator-shardingsphere/issues/4867#issuecomment-601644730
 
 
   ### TODO list to handle this issue
   - [ ] Correct the `TOP` definition in `DMLStatement.g4` of `SQLServer` referring to [DOC](https://www.sqlservertutorial.net/sql-server-basics/sql-server-select-top/).
   - [ ] Add function `visitTop()` of `SQLServerDMLVisitor` to parse out `TopProjectionSegment`
   - [ ] Modify `visitProjection()` of `SQLServerDMLVisitor`
   - [ ] Check those sql test case[1] are correct or not. 
       * If correct, remove the comments from them, and delete the relative sentences in `isPassedSqlCase()` of `SQLParserParameterizedTest` 
       * If incorrect, revise them, and delete the relative sentences in `isPassedSqlCase()` of `SQLParserParameterizedTest` 
   - [ ] Modify the corresponding parsed results in [2] to make `SQLParserParameterizedTest` run well.
   
   [1] All the SQL cases containing `TOP` located in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination.xml` and `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination-group-by-order-by.xml`
   
   [2] ./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services