You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/22 08:43:52 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request, #4024: perf-regresssion: fix number format exception when java and mvnw don'…
aldettinger opened a new pull request, #4024:
URL: https://github.com/apache/camel-quarkus/pull/4024
…t have same default locale #4014
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4024: perf-regresssion: fix number format exception when java and mvnw don'…
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #4024:
URL: https://github.com/apache/camel-quarkus/pull/4024#issuecomment-1222815381
@zbendhiba The reported error message seems to indicate that the expected for the `nominalShouldPrintReport` integration-test is locale dependent. I can't reproduce this though, steps to reproduce would help here.
Overriding the default locale in sub-processes with MAVEN_OPTS would put us in a more secure/repeatable situation to the price of overriding some environment settings made by users for good reasons. For instance, maybe there is a good reason that the default locale is different between java and maven on your machine ? Or do you think it would always be safe to override the default locale ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4024: perf-regresssion: fix number format exception when java and mvnw don'…
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #4024:
URL: https://github.com/apache/camel-quarkus/pull/4024#issuecomment-1224074326
Actually, both ways could work. I've opted to use a fixed en_US locale:
+ for interactions between the tool and underlying maven builds
+ when the tool format the report that will be printed to the console
This should work as soon as:
+ using `-Duser.language=...` has precedence over other ways of overriding the default locale
+ when passing mutliple `-user.language=` statements to the JVM, only the last takes effect
+ the en_US locale is available on all JREs
If overriding user environments/configs/variables generate other issues. Then we could still fallback to the initial solution with a regex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4024: perf-regresssion: fix number format exception when java and mvnw don'…
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #4024:
URL: https://github.com/apache/camel-quarkus/pull/4024#issuecomment-1223774971
The code formatting the double is from the hyperfoil-maven-plugin, not sure they would like to override the default locale with java code. Plus it would need a release. Anyway, it should be possible to do it on our side [with MAVEN_OPTS](https://github.com/apache/camel-quarkus/blob/main/tooling/perf-regression/src/main/java/org/apache/camel/quarkus/performance/regression/MvnwCmdHelper.java#L71).
Concerning native, there is no need for native support in the tool itself. The sample application under test could also be tested in native with the `-an` option. This is already working without tweaking locales.
The current PR should work as soon as java and maven have the same default locale. However itests are not working.
For instance, below would be expected to work:
```
mvn clean install -Dquickly
java -jar target/quarkus-app/quarkus-run.jar -d 1s 2.11.0
```
Thanks for sharing the way to reproduce. Experimenting with that should help to identify the best solution :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4024: perf-regresssion: fix number format exception when java and mvnw don'…
Posted by GitBox <gi...@apache.org>.
aldettinger commented on PR #4024:
URL: https://github.com/apache/camel-quarkus/pull/4024#issuecomment-1222047467
@zbendhiba Time permitting, it would be awesome if this PR could be tested in an environment where the bug is truly reproduceable. More info in #4014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #4024: perf-regresssion: fix number format exception when java and mvnw don'…
Posted by GitBox <gi...@apache.org>.
aldettinger merged PR #4024:
URL: https://github.com/apache/camel-quarkus/pull/4024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #4024: perf-regresssion: fix number format exception when java and mvnw don'…
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on PR #4024:
URL: https://github.com/apache/camel-quarkus/pull/4024#issuecomment-1223749807
I was thinking of setting in the code with Java. If this meant to be executed also for native mode. Add this to the configuration:
```
quarkus.native.user-country=US
quarkus.native.user-language=en
```
Just to prevent it from failing locally, as Double is different regarding to our native languages. My laptop is setup with French language by default.
To reproduce on Linux, you can change the Locale this way : `export LANG=de_DE.UTF-8` in a terminal, before executing the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org