You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/02/15 00:53:58 UTC

Review Request 72133: ATLAS-3621: updated HiveHook to not save query-string in multiple attributes - queryText and name

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72133/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, keval bhatt, Mandar Ambawane, mayank jain, Nixon Rodrigues, Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-3621
    https://issues.apache.org/jira/browse/ATLAS-3621


Repository: atlas


Description
-------

- updated HiveHook to set hive_process.name and hive_column_lineage.name to the value in qualifiedName (instead of the query-string)
- updated NotificationHookConsumer to update these attributes similarly, to handle notifications that were generated by earlier hook


Diffs
-----

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java eae88bc92 
  webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 0a41c9535 
  webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java 1127af80d 
  webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java 6e4265584 


Diff: https://reviews.apache.org/r/72133/diff/1/


Testing
-------

- verified that attribute 'name' in hive_process and hive_column_lineage are set to the value in qualifiedName, instead of query-string, by executing a hive query
- precommit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1634


Thanks,

Madhan Neethiraj