[jira] [Commented] (HBASE-14478) A ThreadPoolExecutor with a LinkedBlockingQueue cannot execute tasks concurrently

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906110#comment-14906110 ] 

Hadoop QA commented on HBASE-14478:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12762066/HBASE-14478.patch
  against master branch at commit 5b7894f92ba3e9ff700da1e9194ebb4774d8b71e.
  ATTACHMENT ID: 12762066

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 3 zombie test(s): 	at org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd.testEndToEnd(TestFuzzyRowFilterEndToEnd.java:143)
	at org.apache.hadoop.hbase.replication.regionserver.TestReplicationWALReaderManager.test(TestReplicationWALReaderManager.java:190)
	at org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint.testRegionReplicaWithoutMemstoreReplication(TestRegionReplicaReplicationEndpoint.java:286)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/15708//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/15708//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/15708//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/15708//console

This message is automatically generated.

> A ThreadPoolExecutor with a LinkedBlockingQueue cannot execute tasks concurrently
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-14478
>                 URL: https://issues.apache.org/jira/browse/HBASE-14478
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 2.0.0
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14478.patch
>
>
> In FlushTableSubprocedurePool and SnapshotSubprocedurePool, the ThreadPoolExecutor with a LinkedBlockingQueue is used, and it's corePoolSize and maximumPoolSize are not the same, which can cause the if the number of tasks is larger than corePoolSize, those tasks cannot be executed until old tasks are finished and the number of running tasks is less than corePoolSize. We should use the same value for the corePoolSize and maximumPoolSize if the LinkedBlockingQueue is used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)