You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/03 09:36:20 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #27428: Handle exception during serializing incompatible executor_config object.

uranusjr commented on code in PR #27428:
URL: https://github.com/apache/airflow/pull/27428#discussion_r1012672875


##########
airflow/api_connexion/schemas/task_instance_schema.py:
##########
@@ -33,6 +33,14 @@
 from airflow.utils.state import State
 
 
+class _ExecutorConfigField(fields.String):
+    def _serialize(self, value, attr, obj, **kwargs):
+        try:
+            return super()._serialize(value, attr, obj, **kwargs)
+        except Exception:

Review Comment:
   What exceptions are possible? This `except` seems much too broad to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org