You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/26 21:47:58 UTC
[GitHub] [superset] Steejay opened a new pull request #13363: docs: add design guidelines
Steejay opened a new pull request #13363:
URL: https://github.com/apache/superset/pull/13363
### SUMMARY
Design guidelines have gotten large. This PR moves design guidelines into DESIGNGUIDELINES.md from CONTRIBUTING.md. It also adds design guidelines for buttons.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
n/a
### TEST PLAN
This is a change to documents only therefore there is no test plan required.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #13363: docs: add design guidelines
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #13363:
URL: https://github.com/apache/superset/pull/13363#issuecomment-839210769
@Steejay do we still need to take any action on this, now the the Wiki contains this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #13363: docs: add design guidelines
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #13363:
URL: https://github.com/apache/superset/pull/13363#issuecomment-789249470
+1 on beefing up https://superset.apache.org/docs/contribution and moving contents in `CONTRIBUTING.md` there. The design guideline could potentially also live there as a separate sub-page.
It's nicer to read than a raw markdown and links well with the "Installation and Configuration" guide so first-time developers wouldn't need to jump between multiple sites to get everything they need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Steejay commented on pull request #13363: docs: add design guidelines
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #13363:
URL: https://github.com/apache/superset/pull/13363#issuecomment-839778190
@rusackas nope. I think we can close this. Thanks Evan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13363: docs: add design guidelines
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13363:
URL: https://github.com/apache/superset/pull/13363#issuecomment-786966796
Where design guideline lives worths some discussion as we have a lot more coming. Maintaining them in separate places can be time-consuming.
In reality, it is hard to have contributors to 'study' the guidelines before opening a PR and strictly follow them.
We plan to onboard a "CSS" expert to work closely with our community designers and be responsible for tuning UI, fixing cosmetic issues, etc.. So I think these guidelines are more for this specific team.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13363: docs: add design guidelines
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13363:
URL: https://github.com/apache/superset/pull/13363#issuecomment-786966796
Wiki is a good idea. Where design guideline lives worths some discussion as we have a lot more coming. Maintaining them in separate places can be time-consuming.
In reality, it is hard to have contributors to 'study' the guidelines before opening a PR and strictly follow them.
We plan to onboard a "CSS" expert to work closely with our community designers and be responsible for tuning UI, fixing cosmetic issues, etc.. So I think these guidelines are more for this specific team.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13363: docs: add design guidelines
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13363:
URL: https://github.com/apache/superset/pull/13363#issuecomment-789249470
I think we should beef up https://superset.apache.org/docs/contribution and maybe even move contents in `CONTRIBUTING.md` to the doc site. The design guideline could potentially also live there as a separate sub-page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Steejay edited a comment on pull request #13363: docs: add design guidelines
Posted by GitBox <gi...@apache.org>.
Steejay edited a comment on pull request #13363:
URL: https://github.com/apache/superset/pull/13363#issuecomment-788152835
Agreed. We will be publishing more guidelines in the near future and already with only 2 sections, its getting too large for its current location. ie the capitalization guideline is only one part of the type system category.
The goal of these guidelines is to provide design insights for the community when creating new features/solutions that use common components (buttons, modals, etc). How to use them and when to use them while still providing room for flexibility.
The wiki is probably the best way forward. I think its a good solution that will allow the guidelines to scale.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Steejay closed pull request #13363: docs: add design guidelines
Posted by GitBox <gi...@apache.org>.
Steejay closed pull request #13363:
URL: https://github.com/apache/superset/pull/13363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Steejay commented on pull request #13363: docs: add design guidelines
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #13363:
URL: https://github.com/apache/superset/pull/13363#issuecomment-788152835
Agreed. We will be publishing more guidelines in the near future and already with only 2 sections, its getting too large for its current location. ie the capitalization guideline is only one part of the type system category.
The goal of these guidelines is to provide design insights for the community when creating new features/solutions that use common components (buttons, modals, etc). How to use them and when to use them while still providing room for flexibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify commented on pull request #13363: docs: add design guidelines
Posted by GitBox <gi...@apache.org>.
srinify commented on pull request #13363:
URL: https://github.com/apache/superset/pull/13363#issuecomment-789187841
FWIW, I'm planning on refactoring CONTRIBUTING.MD and potentially either moving some things to the Superset site or cleaning up into potentially multiple files. It's becoming unruly, either way I'll solicit input before making changes!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org