You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by sw...@apache.org on 2018/01/22 21:10:11 UTC

[ambari] branch trunk updated: AMBARI-22696 Whitelist execute latency from Storm Ambari metrics

This is an automated email from the ASF dual-hosted git repository.

swagle pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ambari.git


The following commit(s) were added to refs/heads/trunk by this push:
     new b275722  AMBARI-22696 Whitelist execute latency from Storm Ambari metrics
b275722 is described below

commit b275722355c7e67af918a18a8b90c684e5837af0
Author: Jungtaek Lim <ka...@gmail.com>
AuthorDate: Tue Jan 23 05:21:28 2018 +0900

    AMBARI-22696 Whitelist execute latency from Storm Ambari metrics
---
 .../common-services/STORM/1.0.1.3.0/configuration/storm-site.xml        | 2 +-
 .../main/resources/common-services/STORM/1.0.1.3.0/service_advisor.py   | 1 +
 .../resources/common-services/STORM/1.0.1/configuration/storm-site.xml  | 2 +-
 .../src/main/resources/stacks/HDP/2.5/services/stack_advisor.py         | 1 +
 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py   | 1 +
 5 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/configuration/storm-site.xml b/ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/configuration/storm-site.xml
index 6b97fb6..61cd168 100644
--- a/ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/configuration/storm-site.xml
+++ b/ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/configuration/storm-site.xml
@@ -918,7 +918,7 @@
     </property>
     <property>
         <name>topology.metrics.consumer.register</name>
-        <value>[{"class": "org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsSink", "parallelism.hint": 1, "whitelist": ["kafkaOffset\\..+/", "__complete-latency", "__process-latency", "__receive\\.population$", "__sendqueue\\.population$", "__execute-count", "__emit-count", "__ack-count", "__fail-count", "memory/heap\\.usedBytes$", "memory/nonHeap\\.usedBytes$", "GC/.+\\.count$", "GC/.+\\.timeMs$"]}]</value>
+        <value>[{"class": "org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsSink", "parallelism.hint": 1, "whitelist": ["kafkaOffset\\..+/", "__complete-latency", "__process-latency", "__execute-latency", "__receive\\.population$", "__sendqueue\\.population$", "__execute-count", "__emit-count", "__ack-count", "__fail-count", "memory/heap\\.usedBytes$", "memory/nonHeap\\.usedBytes$", "GC/.+\\.count$", "GC/.+\\.timeMs$"]}]</value>
         <description></description>
         <value-attributes>
             <overridable>false</overridable>
diff --git a/ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/service_advisor.py b/ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/service_advisor.py
index 1d6bbe0..95a9dd9 100644
--- a/ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/service_advisor.py
+++ b/ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/service_advisor.py
@@ -304,6 +304,7 @@ class StormRecommender(service_advisor.ServiceAdvisor):
                            '[{"class": "org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsSink", '
                            '"parallelism.hint": 1, '
                            '"whitelist": ["kafkaOffset\\\..+/", "__complete-latency", "__process-latency", '
+                           '"__execute-latency", '
                            '"__receive\\\.population$", "__sendqueue\\\.population$", "__execute-count", "__emit-count", '
                            '"__ack-count", "__fail-count", "memory/heap\\\.usedBytes$", "memory/nonHeap\\\.usedBytes$", '
                            '"GC/.+\\\.count$", "GC/.+\\\.timeMs$"]}]')
diff --git a/ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml b/ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
index 558beaf..71e217e 100644
--- a/ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
+++ b/ambari-server/src/main/resources/common-services/STORM/1.0.1/configuration/storm-site.xml
@@ -128,7 +128,7 @@
   </property>
   <property>
     <name>topology.metrics.consumer.register</name>
-    <value>[{"class": "org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsSink", "parallelism.hint": 1, "whitelist": ["kafkaOffset\\..+/", "__complete-latency", "__process-latency", "__receive\\.population$", "__sendqueue\\.population$", "__execute-count", "__emit-count", "__ack-count", "__fail-count", "memory/heap\\.usedBytes$", "memory/nonHeap\\.usedBytes$", "GC/.+\\.count$", "GC/.+\\.timeMs$"]}]</value>
+    <value>[{"class": "org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsSink", "parallelism.hint": 1, "whitelist": ["kafkaOffset\\..+/", "__complete-latency", "__process-latency", "__execute-latency", "__receive\\.population$", "__sendqueue\\.population$", "__execute-count", "__emit-count", "__ack-count", "__fail-count", "memory/heap\\.usedBytes$", "memory/nonHeap\\.usedBytes$", "GC/.+\\.count$", "GC/.+\\.timeMs$"]}]</value>
     <description></description>
     <value-attributes>
       <overridable>false</overridable>
diff --git a/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py b/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
index 6f409cd..f069ed4 100644
--- a/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
+++ b/ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
@@ -541,6 +541,7 @@ class HDP25StackAdvisor(HDP24StackAdvisor):
                            '[{"class": "org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsSink", '
                            '"parallelism.hint": 1, '
                            '"whitelist": ["kafkaOffset\\\..+/", "__complete-latency", "__process-latency", '
+                           '"__execute-latency", '
                            '"__receive\\\.population$", "__sendqueue\\\.population$", "__execute-count", "__emit-count", '
                            '"__ack-count", "__fail-count", "memory/heap\\\.usedBytes$", "memory/nonHeap\\\.usedBytes$", '
                            '"GC/.+\\\.count$", "GC/.+\\\.timeMs$"]}]')
diff --git a/ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py b/ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py
index cc6bd9d..bfac76b 100644
--- a/ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py
+++ b/ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py
@@ -6040,6 +6040,7 @@ class TestHDP25StackAdvisor(TestCase):
     self.assertEquals(configurations['storm-site']['properties']['topology.metrics.consumer.register'], '[{"class": "org.apache.hadoop.metrics2.sink.storm.StormTimelineMetricsSink", '
                                                                                                       '"parallelism.hint": 1, '
                                                                                                       '"whitelist": ["kafkaOffset\\\..+/", "__complete-latency", "__process-latency", '
+                                                                                                      '"__execute-latency", '
                                                                                                       '"__receive\\\.population$", "__sendqueue\\\.population$", "__execute-count", "__emit-count", '
                                                                                                       '"__ack-count", "__fail-count", "memory/heap\\\.usedBytes$", "memory/nonHeap\\\.usedBytes$", '
                                                                                                       '"GC/.+\\\.count$", "GC/.+\\\.timeMs$"]}]')

-- 
To stop receiving notification emails like this one, please contact
swagle@apache.org.