You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2009/03/09 19:15:50 UTC
[jira] Created: (HADOOP-5442) The job history display needs to be
paged
The job history display needs to be paged
------------------------------------------
Key: HADOOP-5442
URL: https://issues.apache.org/jira/browse/HADOOP-5442
Project: Hadoop Core
Issue Type: Bug
Reporter: Owen O'Malley
Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5442) The job history display needs to be
paged
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat reassigned HADOOP-5442:
----------------------------------
Assignee: Amar Kamat
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Amar Kamat
> Attachments: HADOOP-5442-v1.6.patch, HADOOP-5442-v1.9.patch
>
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5442) The job history display needs to be
paged
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated HADOOP-5442:
-------------------------------
Attachment: HADOOP-5442-v1.9.patch
Attaching a patch incorporating offline comments from Devaraj and Hemanth. The changes are as follows
# searching now allows jobname searching
# start-index is not longed used. Pageno is used to display pages
# A last page link is provided
Result of test-patch is as follows :
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{code}
Findbugs warning is because of passing the search string across calls.
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Attachments: HADOOP-5442-v1.6.patch, HADOOP-5442-v1.9.patch
>
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5442) The job history display needs to be
paged
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682404#action_12682404 ]
Jothi Padmanabhan commented on HADOOP-5442:
-------------------------------------------
Patch looks fine.
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Amar Kamat
> Attachments: HADOOP-5442-v1.12.patch, HADOOP-5442-v1.6.patch, HADOOP-5442-v1.9.patch
>
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5442) The job history display needs to be
paged
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682224#action_12682224 ]
Amar Kamat commented on HADOOP-5442:
------------------------------------
Currently testing the patch. Patch applies to 0.20. Result of test-patch
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{code}
Findbugs warning is because the user name is displayed on the webpage.
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Attachments: HADOOP-5442-v1.6.patch
>
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5442) The job history display needs to be
paged
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated HADOOP-5442:
-------------------------------
Attachment: HADOOP-5442-v1.12.patch
Attaching a patch incorporating Jothi's comments and Devaraj's offline comments.
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Amar Kamat
> Attachments: HADOOP-5442-v1.12.patch, HADOOP-5442-v1.6.patch, HADOOP-5442-v1.9.patch
>
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-5442) The job history display needs to be
paged
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy resolved HADOOP-5442.
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
I just committed this. Thanks, Amar!
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Amar Kamat
> Fix For: 0.21.0
>
> Attachments: HADOOP-5442-v1.12.patch, HADOOP-5442-v1.6.patch, HADOOP-5442-v1.9.patch
>
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5442) The job history display needs to be
paged
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680371#action_12680371 ]
Amar Kamat commented on HADOOP-5442:
------------------------------------
HADOOP-4670 should take care of this, no?
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5442) The job history display needs to be
paged
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amar Kamat updated HADOOP-5442:
-------------------------------
Attachment: HADOOP-5442-v1.6.patch
Attaching a patch that does
# Pagination
# Adds search based on user
# Back link from jobhistory to jobtracker
Todo :
# Add searching on other parameters too like jobname.
# Show users-level grouping by default
# Group by date instead of showing all in one table
For now we feel the current patch should serve the purpose. Todo's can be incorporated later.
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Attachments: HADOOP-5442-v1.6.patch
>
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5442) The job history display needs to be
paged
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683090#action_12683090 ]
Hudson commented on HADOOP-5442:
--------------------------------
Integrated in Hadoop-trunk #783 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/783/])
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Amar Kamat
> Fix For: 0.21.0
>
> Attachments: HADOOP-5442-v1.12.patch, HADOOP-5442-v1.6.patch, HADOOP-5442-v1.9.patch
>
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5442) The job history display needs to be
paged
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682405#action_12682405 ]
Amar Kamat commented on HADOOP-5442:
------------------------------------
Result of test-patch
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
{code}
The findbugs warning is
{noformat}
HTTP parameter directly written to JSP output, giving reflected XSS vulnerability in org.apache.hadoop.mapred.jobhistory_jsp
In class org.apache.hadoop.mapred.jobhistory_jsp
In method org.apache.hadoop.mapred.jobhistory_jsp._jspService(HttpServletRequest, HttpServletResponse)
Parameter 'search' Value generated at jobhistory_jsp.java:[line 146]
At jobhistory_jsp.java:[line 226]
Another occurrence at jobhistory_jsp.java:[line 249]
Another occurrence at jobhistory_jsp.java:[line 253]
Another occurrence at jobhistory_jsp.java:[line 260]
{noformat}
Here the search string is passed across pages.
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Amar Kamat
> Attachments: HADOOP-5442-v1.12.patch, HADOOP-5442-v1.6.patch, HADOOP-5442-v1.9.patch
>
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5442) The job history display needs to be
paged
Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682385#action_12682385 ]
Jothi Padmanabhan commented on HADOOP-5442:
-------------------------------------------
Tested the patch. Looks good. A few minor points
# Having a standalone : to imply allusers:alljobs caused an ArrayOutOfBounds Exception
# I think the quotes surrounding the job numbers in the display (Displaying '1829' jobs from '1' to '1829' out of '1829' jobs) can be removed
# Adding a "First Page" link similar to "Last page" might be useful. This is not important though, we could get back to the first page from the filter if this option is not there.
# On Choosing "Last page" option from a "Show all" result page, it gives the first page and not the last page.
> The job history display needs to be paged
> ------------------------------------------
>
> Key: HADOOP-5442
> URL: https://issues.apache.org/jira/browse/HADOOP-5442
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Amar Kamat
> Attachments: HADOOP-5442-v1.6.patch, HADOOP-5442-v1.9.patch
>
>
> Currently the list of job history will try to render the entire list of jobs that have run. That doesn't scale up as more and more jobs run on a job tracker.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.