[GitHub] [incubator-superset] ktmud commented on a change in pull request #10850: feat: server side dashboard css for less repaint

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850#discussion_r487354166



##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">

Review comment:
       Must add this class so that live-edits can updating previous CSS.

##########
File path: superset/templates/superset/dashboard.html
##########
@@ -18,6 +18,15 @@
 #}
 {% extends "superset/basic.html" %}
 
+{% block head_css %}
+  {{ super() }}
+  {% if custom_css %}
+  <style class="CssEditor-css" type="text/css">
+    {{ custom_css }}

Review comment:
       malicious strings should be escaped by Jinja.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org