You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by parthchandra <gi...@git.apache.org> on 2016/01/29 02:57:13 UTC
[GitHub] drill pull request: Drill 4313 - Improve method of picking a rando...
GitHub user parthchandra opened a pull request:
https://github.com/apache/drill/pull/346
Drill 4313 - Improve method of picking a random drillbit from the C++ client
There are two changes here -
1) Set the seed for the random generator only at initialization time
2) Use a random shuffle on the list of drillbits and pick one after this. For a small sample of drillbits, this seems to give a more uniform selection of drillbits.
Also a protobuf class changed so some code had to be updated for that. Included as a separate commit in the PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/parthchandra/incubator-drill DRILL-4313
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/346.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #346
----
commit 46fdd93880156bc7aaabeb876af7a5c6da0aa666
Author: Parth Chandra <pa...@apache.org>
Date: 2016-01-26T19:55:59Z
DRILL-4313: Update build for protobuf changes
commit a90283a3bb2c0447e26a73994026dc773a9bdda9
Author: Parth Chandra <pa...@apache.org>
Date: 2016-01-27T18:20:39Z
DRILL-4313: CPP client - Improve method to pick random drillbit from a cluster.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: Drill 4313 - Improve method of picking a rando...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/346
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: Drill 4313 - Improve method of picking a rando...
Posted by amansinha100 <gi...@git.apache.org>.
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/346#issuecomment-176544443
+1. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---