You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tubemq.apache.org by go...@apache.org on 2020/02/18 06:26:08 UTC

[incubator-tubemq] branch master updated: [TUBEMQ-33] refactor enum implemention of inner annoynmous (#24)

This is an automated email from the ASF dual-hosted git repository.

gosonzhang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tubemq.git


The following commit(s) were added to refs/heads/master by this push:
     new 7c69d91  [TUBEMQ-33] refactor enum implemention of inner annoynmous (#24)
7c69d91 is described below

commit 7c69d9107b5998e0b9833e3e414097c892b26ba2
Author: Aloys <18...@163.com>
AuthorDate: Tue Feb 18 14:25:59 2020 +0800

    [TUBEMQ-33] refactor enum implemention of inner annoynmous (#24)
---
 .../tubemq/corebase/balance/EventStatus.java       | 100 +++++---------
 .../apache/tubemq/corebase/balance/EventType.java  | 145 +++++++--------------
 2 files changed, 82 insertions(+), 163 deletions(-)

diff --git a/tubemq-core/src/main/java/org/apache/tubemq/corebase/balance/EventStatus.java b/tubemq-core/src/main/java/org/apache/tubemq/corebase/balance/EventStatus.java
index 33ae864..2435b77 100644
--- a/tubemq-core/src/main/java/org/apache/tubemq/corebase/balance/EventStatus.java
+++ b/tubemq-core/src/main/java/org/apache/tubemq/corebase/balance/EventStatus.java
@@ -18,67 +18,36 @@
 package org.apache.tubemq.corebase.balance;
 
 public enum EventStatus {
-    DONE() {
-        @Override
-        public int getValue() {
-            return 2;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Process Done";
-        }
-    },
-
-    FAILED() {
-        @Override
-        public int getValue() {
-            return -2;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Process failed";
-        }
-    },
-
-    PROCESSING() {
-        @Override
-        public int getValue() {
-            return 1;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Being processed";
-        }
-    },
-
-
-    TODO() {
-        @Override
-        public int getValue() {
-            return 0;
-        }
-
-        @Override
-        public String getDesc() {
-            return "To be processed";
-        }
-    },
-
-    UNKNOWN() {
-        @Override
-        public int getValue() {
-            return -1;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Unknown event status";
-        }
-    };
-
+    /**
+     * To be processed state.
+     * */
+    TODO(0, "To be processed"),
+    /**
+     * On processing state.
+     * */
+    PROCESSING(1, "Being processed"),
+    /**
+     * Processed state.
+     * */
+    DONE(2, "Process Done"),
+
+    /**
+     * Unknown state.
+     * */
+    UNKNOWN(-1, "Unknown event status"),
+    /**
+     * Failed state.
+     * */
+    FAILED(-2, "Process failed");
+
+
+    private int value;
+    private String description;
+
+    EventStatus(int value, String description) {
+        this.value = value;
+        this.description = description;
+    }
     public static EventStatus valueOf(int value) {
         for (EventStatus status : EventStatus.values()) {
             if (status.getValue() == value) {
@@ -89,9 +58,12 @@ public enum EventStatus {
         return UNKNOWN;
     }
 
-    public abstract int getValue();
-
-    public abstract String getDesc();
+    public int getValue() {
+        return value;
+    }
+    public String getDesc(){
+        return description;
+    }
 
 }
 
diff --git a/tubemq-core/src/main/java/org/apache/tubemq/corebase/balance/EventType.java b/tubemq-core/src/main/java/org/apache/tubemq/corebase/balance/EventType.java
index b0193c8..f98da99 100644
--- a/tubemq-core/src/main/java/org/apache/tubemq/corebase/balance/EventType.java
+++ b/tubemq-core/src/main/java/org/apache/tubemq/corebase/balance/EventType.java
@@ -18,101 +18,52 @@
 package org.apache.tubemq.corebase.balance;
 
 public enum EventType {
-    CONNECT() {
-        @Override
-        public int getValue() {
-            return 1;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Connect to some broker after Disconnecting from some other broker.";
-        }
-    },
-
-    ONLY_CONNECT() {
-        @Override
-        public int getValue() {
-            return 10;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Only connect to some broker";
-        }
-    },
-
-    DISCONNECT() {
-        @Override
-        public int getValue() {
-            return 2;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Disconnect from some broker.";
-        }
-    },
-
-    ONLY_DISCONNECT() {
-        @Override
-        public int getValue() {
-            return 20;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Disconnect from some broker,then finish.";
-        }
-
-    },
-
-    REPORT() {
-        @Override
-        public int getValue() {
-            return 3;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Report current status.";
-        }
-    },
-    REFRESH() {
-        @Override
-        public int getValue() {
-            return 4;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Update whole producer published topic info";
-        }
-    },
-    STOPREBALANCE() {
-        @Override
-        public int getValue() {
-            return 5;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Stop rebalance thread";
-        }
-    },
-
-    UNKNOWN() {
-        @Override
-        public int getValue() {
-            return -1;
-        }
-
-        @Override
-        public String getDesc() {
-            return "Unknown operation type";
-        }
-    };
-
+    /**
+     * Connect to broker.
+     * */
+    CONNECT(1, "Connect to some broker after Disconnecting from some other broker."),
+    /**
+     * DisConnect from broker.
+     * */
+    DISCONNECT(2, "Disconnect from some broker."),
+    /**
+     * Report state.
+     * */
+    REPORT(3, "Report current status."),
+    /**
+     * Update producer published topic information.
+     * */
+    REFRESH(4, "Update whole producer published topic info"),
+    /**
+     * Stop re-balance thread.
+     * */
+    STOPREBALANCE(5, "Stop rebalance thread"),
+    /**
+     * Connect to some broker only.
+     * */
+    ONLY_CONNECT(10, "Only connect to some broker"),
+    /**
+     * Disconnect from broker and finish.
+     * */
+    ONLY_DISCONNECT(20, "Disconnect from some broker,then finish."),
+    /**
+     * Unknown operation.
+     * */
+    UNKNOWN(-1, "Unknown operation type");
+
+    private int value;
+    private String description;
+
+    EventType(int value, String description) {
+        this.value = value;
+        this.description = description;
+    }
+    public  int getValue() {
+        return value;
+    }
+    public String getDesc() {
+        return description;
+    }
     public static EventType valueOf(int value) {
         for (EventType type : EventType.values()) {
             if (type.getValue() == value) {
@@ -122,8 +73,4 @@ public enum EventType {
         return UNKNOWN;
     }
 
-    public abstract int getValue();
-
-    public abstract String getDesc();
-
 }