You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/25 18:53:30 UTC
[GitHub] [hive] achennagiri opened a new pull request #1906: Hive 24348 - Isolating dependencies and execution with Java for Beeline(Abhay Chennagiri)
achennagiri opened a new pull request #1906:
URL: https://github.com/apache/hive/pull/1906
### What changes were proposed in this pull request?
1) Changes to use java to execute beeline if HADOOP_HOME is not set.
2) POM changes to build a standalone distributable zip file containing beeline and it's dependencies.
3) Eliminates some of the not required jars in classpath for beeline.
This PR borrows some of the code from https://github.com/apache/hive/pull/1852. The only difference is that we are bundling the beeline and jdbc jars in to a single, downloadable tarball rather than creating an uber beeline-with-dependencies jar.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Currently beeline has a bunch of dependencies on other jars, some required and some unnecessary. beeline script also uses HADOOP_HOME to execute beeline class. This adds some other jars to the classpath that makes it hard to run beeline on an edge node. This fix is a first pass at building a standalone package with all needed dependencies and also make it work using "java" when HADOOP_HOME is not set.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on a change in pull request #1906: Hive 24348 - Isolating dependencies and execution with Java for Beeline(Abhay Chennagiri)
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on a change in pull request #1906:
URL: https://github.com/apache/hive/pull/1906#discussion_r570353101
##########
File path: bin/hive
##########
@@ -89,15 +86,12 @@ if [ "$SERVICE" = "" ] ; then
fi
fi
+USE_BEELINE_FOR_HIVE_CLI="true"
if [[ "$SERVICE" == "cli" && "$USE_BEELINE_FOR_HIVE_CLI" == "true" ]] ; then
CLIUSER=`whoami`
SERVICE="beeline"
fi
-if [[ "$SERVICE" == "beeline" && ! -z "$BEELINE_URL_LEGACY" ]] ; then
Review comment:
@achennagiri I am not sure why has this been deleted by me, but this should still be supported.
This was added to enable beeline to automatically pick a connection string based on an environment variable (beeline profile). Could you add is back and test this functionality please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1906: Hive 24348 - Isolating dependencies and execution with Java for Beeline(Abhay Chennagiri)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1906:
URL: https://github.com/apache/hive/pull/1906#issuecomment-855489350
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] achennagiri commented on a change in pull request #1906: Hive 24348 - Isolating dependencies and execution with Java for Beeline(Abhay Chennagiri)
Posted by GitBox <gi...@apache.org>.
achennagiri commented on a change in pull request #1906:
URL: https://github.com/apache/hive/pull/1906#discussion_r576682345
##########
File path: bin/hive
##########
@@ -89,15 +86,12 @@ if [ "$SERVICE" = "" ] ; then
fi
fi
+USE_BEELINE_FOR_HIVE_CLI="true"
if [[ "$SERVICE" == "cli" && "$USE_BEELINE_FOR_HIVE_CLI" == "true" ]] ; then
CLIUSER=`whoami`
SERVICE="beeline"
fi
-if [[ "$SERVICE" == "beeline" && ! -z "$BEELINE_URL_LEGACY" ]] ; then
Review comment:
Yes. I have added these lines and tested it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] achennagiri commented on pull request #1906: Hive 24348 - Isolating dependencies and execution with Java for Beeline(Abhay Chennagiri)
Posted by GitBox <gi...@apache.org>.
achennagiri commented on pull request #1906:
URL: https://github.com/apache/hive/pull/1906#issuecomment-767219283
@belugabehr Can you please review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] achennagiri commented on pull request #1906: Hive 24348 - Isolating dependencies and execution with Java for Beeline(Abhay Chennagiri)
Posted by GitBox <gi...@apache.org>.
achennagiri commented on pull request #1906:
URL: https://github.com/apache/hive/pull/1906#issuecomment-767219283
@belugabehr Can you please review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1906: Hive 24348 - Isolating dependencies and execution with Java for Beeline(Abhay Chennagiri)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1906:
URL: https://github.com/apache/hive/pull/1906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org