You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by br...@apache.org on 2004/07/10 04:15:39 UTC
cvs commit: jakarta-commons/jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml AttributeTag.java
brett 2004/07/09 19:15:39
Modified: jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml
AttributeTag.java
Log:
Don't encode the conents of the attribute
Revision Changes Path
1.5 +2 -2 jakarta-commons/jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml/AttributeTag.java
Index: AttributeTag.java
===================================================================
RCS file: /home/cvs/jakarta-commons/jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml/AttributeTag.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- AttributeTag.java 25 Feb 2004 01:31:50 -0000 1.4
+++ AttributeTag.java 10 Jul 2004 02:15:39 -0000 1.5
@@ -41,7 +41,7 @@
if ( tag == null ) {
throw new JellyTagException( "<attribute> tag must be enclosed inside an <element> tag" );
}
- tag.setAttributeValue( getName(), getBodyText() );
+ tag.setAttributeValue( getName(), getBodyText( false ) );
}
// Properties
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-commons/jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml
AttributeTag.java
Posted by Brett Porter <br...@apache.org>.
No, but that makes sense.
I can't think of any reason why you'd want it to be true? The content of
the attribute element is already encoded to the same level you'd need in
the attribute, and this change makes the behaviour consistent with
XSLT's attribute tag.
Cheers,
Brett
Dion Gillard wrote:
>Is there an encode property on the attribute tag? I really think it's
>something we could do with across all tags, like trim.
>
>On 10 Jul 2004 02:15:39 -0000, brett@apache.org <br...@apache.org> wrote:
>
>
>>brett 2004/07/09 19:15:39
>>
>> Modified: jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml
>> AttributeTag.java
>> Log:
>> Don't encode the conents of the attribute
>>
>> Revision Changes Path
>> 1.5 +2 -2 jakarta-commons/jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml/AttributeTag.java
>>
>> Index: AttributeTag.java
>> ===================================================================
>> RCS file: /home/cvs/jakarta-commons/jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml/AttributeTag.java,v
>> retrieving revision 1.4
>> retrieving revision 1.5
>> diff -u -r1.4 -r1.5
>> --- AttributeTag.java 25 Feb 2004 01:31:50 -0000 1.4
>> +++ AttributeTag.java 10 Jul 2004 02:15:39 -0000 1.5
>> @@ -41,7 +41,7 @@
>> if ( tag == null ) {
>> throw new JellyTagException( "<attribute> tag must be enclosed inside an <element> tag" );
>> }
>> - tag.setAttributeValue( getName(), getBodyText() );
>> + tag.setAttributeValue( getName(), getBodyText( false ) );
>> }
>>
>> // Properties
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
>>
>>
>>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: cvs commit: jakarta-commons/jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml AttributeTag.java
Posted by Dion Gillard <di...@gmail.com>.
Is there an encode property on the attribute tag? I really think it's
something we could do with across all tags, like trim.
On 10 Jul 2004 02:15:39 -0000, brett@apache.org <br...@apache.org> wrote:
> brett 2004/07/09 19:15:39
>
> Modified: jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml
> AttributeTag.java
> Log:
> Don't encode the conents of the attribute
>
> Revision Changes Path
> 1.5 +2 -2 jakarta-commons/jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml/AttributeTag.java
>
> Index: AttributeTag.java
> ===================================================================
> RCS file: /home/cvs/jakarta-commons/jelly/jelly-tags/xml/src/java/org/apache/commons/jelly/tags/xml/AttributeTag.java,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- AttributeTag.java 25 Feb 2004 01:31:50 -0000 1.4
> +++ AttributeTag.java 10 Jul 2004 02:15:39 -0000 1.5
> @@ -41,7 +41,7 @@
> if ( tag == null ) {
> throw new JellyTagException( "<attribute> tag must be enclosed inside an <element> tag" );
> }
> - tag.setAttributeValue( getName(), getBodyText() );
> + tag.setAttributeValue( getName(), getBodyText( false ) );
> }
>
> // Properties
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
--
http://www.multitask.com.au/people/dion/
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org