You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/18 18:54:47 UTC
[GitHub] [spark] gatorsmile commented on a change in pull request #27550:
[SPARK-30799][SQL] "spark_catalog.t" should not be resolved to temp view
gatorsmile commented on a change in pull request #27550: [SPARK-30799][SQL] "spark_catalog.t" should not be resolved to temp view
URL: https://github.com/apache/spark/pull/27550#discussion_r380868610
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala
##########
@@ -94,6 +94,10 @@ private[sql] trait LookupCatalog extends Logging {
* Extract catalog and identifier from a multi-part name with the current catalog if needed.
* Catalog name takes precedence over identifier, but for a single-part name, identifier takes
* precedence over catalog name.
+ *
+ * Note that, this pattern is used to look up permanent catalog objects like table, view,
+ * function, etc. If you need to look up temp objects like temp view, please do it separately
+ * before calling this pattern, as temp objects don't belong to any catalog.
Review comment:
The term `Catalog` is being used in many places. For example, our internal SessionCatalog also manages temp objects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org