[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #40089: [SPARK-42495][CONNECT] Scala Client add Misc, String, and Date/Time functions

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #40089:
URL: https://github.com/apache/spark/pull/40089#discussion_r1111478919


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -2238,6 +2238,1359 @@ object functions {
    */
   def radians(columnName: String): Column = radians(Column(columnName))
 
+  //////////////////////////////////////////////////////////////////////////////////////////////
+  // Misc functions
+  //////////////////////////////////////////////////////////////////////////////////////////////
+
+  /**
+   * Calculates the MD5 digest of a binary column and returns the value as a 32 character hex
+   * string.
+   *
+   * @group misc_funcs
+   * @since 1.5.0

Review Comment:
   Ur, I'm a little confused. Is it correct, @hvanhovell and @zhengruifeng ?
   
   cc @HyukjinKwon 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org