You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/01/05 01:24:32 UTC
Review Request 69671: Always build gRPC with its embedded c-ares.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69671/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-9505
https://issues.apache.org/jira/browse/MESOS-9505
Repository: mesos
Description
-------
We compile gRPC with its embedded c-ares library to avoid a link error
because Mesos is not aware of the library.
Diffs
-----
3rdparty/Makefile.am a14216cf98f6638da06aa3dfc49e6b319fea7f87
Diff: https://reviews.apache.org/r/69671/diff/1/
Testing
-------
make check with c-ares pre-installed on mac and ubuntu.
Thanks,
Chun-Hung Hsiao
Re: Review Request 69671: Always build gRPC with its embedded c-ares.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69671/#review211701
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/Makefile.am
Lines 500 (patched)
<https://reviews.apache.org/r/69671/#comment297209>
Can you add some comments about this one? Or just separate this change in a different patch?
- Jie Yu
On Jan. 5, 2019, 1:24 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69671/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2019, 1:24 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-9505
> https://issues.apache.org/jira/browse/MESOS-9505
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We compile gRPC with its embedded c-ares library to avoid a link error
> because Mesos is not aware of the library.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am a14216cf98f6638da06aa3dfc49e6b319fea7f87
>
>
> Diff: https://reviews.apache.org/r/69671/diff/1/
>
>
> Testing
> -------
>
> make check with c-ares pre-installed on mac and ubuntu.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69671: Always build gRPC with its embedded c-ares.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69671/
-----------------------------------------------------------
(Updated Jan. 7, 2019, 8:18 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Addressed Jie's comment.
Bugs: MESOS-9505
https://issues.apache.org/jira/browse/MESOS-9505
Repository: mesos
Description
-------
We compile gRPC with its embedded c-ares library to avoid a link error
because Mesos is not aware of the library.
Diffs (updated)
-----
3rdparty/Makefile.am a14216cf98f6638da06aa3dfc49e6b319fea7f87
Diff: https://reviews.apache.org/r/69671/diff/2/
Changes: https://reviews.apache.org/r/69671/diff/1-2/
Testing
-------
make check with c-ares pre-installed on mac and ubuntu.
Thanks,
Chun-Hung Hsiao