[jira] [Commented] (CASSANDRA-15227) Remove StageManager

["Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-15227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898987#comment-16898987 ] 

Benedict commented on CASSANDRA-15227:
--------------------------------------

Thanks [~n.v.harikrishna]!

The patch looks good overall, just some stylistic nits (that we could do with finishing the style guide for):

# We generally prefer to avoid extraneous words in method and property names, and to avoid getters where possible, so some suggestions:
#* {{private final localAwareExecutorService}} -> {{public final executor}} and remove {{getExecutorService()}}
#* {{private final jmxName}} -> {{public final jmxName}} and remove {{getJmxName()}}
#** Honestly it might be nice to try to remove this field entirely, since we only actually need it in one place, and we could eliminate that use case by immediately executing a task on the GOSSIP stage to set {{isInGossipStage}} to true, which would be much less ugly anyway
# I don't think {{toJmxName}} is needed anymore, you can apply the transformation manually to the parameters
# For formatting, could you take a look at {{Verb}}, and how it aligns fields so that it is easier to view?
#* It might not be necessary to accept an {{ExecutorServiceInitialiser}} - it might be possible to cleanly supply the executor directly in each case.  If it makes the formatting cleaner, though, we should ideally have a method we can get a lambda method-reference to for each stage, and move this parameter last, so we can have consistent formatting.  This might well be cleaner than supplying the executor directly, as it might permit more consistent formatting.

> Remove StageManager
> -------------------
>
>                 Key: CASSANDRA-15227
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15227
>             Project: Cassandra
>          Issue Type: Task
>          Components: Local/Other
>            Reporter: Benedict
>            Assignee: Venkata Harikrishna Nukala
>            Priority: Normal
>             Fix For: 4.0
>
>
> his is a minor cleanup; this class should not exist, but should be embedded in the Stage enum.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org