[GitHub] [arrow] lidavidm commented on a change in pull request #12123: ARROW-15300: [C++] Update Skyhook for async dataset interfaces

[GitBox <gi...@apache.org>]

lidavidm commented on a change in pull request #12123:
URL: https://github.com/apache/arrow/pull/12123#discussion_r783339577



##########
File path: cpp/src/skyhook/client/file_skyhook.cc
##########
@@ -95,10 +43,13 @@ class SkyhookFileFormat::Impl {
     return arrow::Status::OK();
   }
 
-  arrow::Result<arrow::dataset::ScanTaskIterator> ScanFile(
+  arrow::Result<arrow::RecordBatchGenerator> ScanBatchesAsync(
+      const std::shared_ptr<const SkyhookFileFormat>& format,
       const std::shared_ptr<arrow::dataset::ScanOptions>& options,
       const std::shared_ptr<arrow::dataset::FileFragment>& file) const {
-    /// Make sure client-side filtering and projection is turned off.
+    // TODO: investigate "true" async version
+
+    // Make sure client-side filtering and projection is turned off.
     file->apply_compute = false;

Review comment:
       Ah, good point. I've gone and removed the flag. We can file a follow up for this case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org