You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda <kk...@cloudera.com> on 2017/10/02 15:11:23 UTC
Re: Review Request 62496: SENTRY-1963: Sentry JSON reporter should use
regular implementation for local file system
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62496/#review186848
-----------------------------------------------------------
Sasha, Could you please explain "what does regular implementation for local file system" mean? That will help get the conetxt what you are trying to do.
- kalyan kumar kalvagadda
On Sept. 22, 2017, 6:28 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62496/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 6:28 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1963
> https://issues.apache.org/jira/browse/SENTRY-1963
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1963: Sentry JSON reporter should use regular implementation for local file system
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java 4063a663c86ea5ed88c40013d5b3550ac0a6272f
>
>
> Diff: https://reviews.apache.org/r/62496/diff/3/
>
>
> Testing
> -------
>
> New unit test written
>
>
> Thanks,
>
> Alexander Kolbasov
>
>
Re: Review Request 62496: SENTRY-1963: Sentry JSON reporter should use
regular implementation for local file system
Posted by Alexander Kolbasov <ak...@gmail.com>.
> On Oct. 2, 2017, 3:11 p.m., kalyan kumar kalvagadda wrote:
> > Sasha, Could you please explain "what does regular implementation for local file system" mean? That will help get the conetxt what you are trying to do.
The original implementation uses Hadoop local filesystem interface which isn't needed here at all - we are much better off using java.nio file system operations instead.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62496/#review186848
-----------------------------------------------------------
On Sept. 22, 2017, 6:28 p.m., Alexander Kolbasov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62496/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2017, 6:28 p.m.)
>
>
> Review request for sentry, Arjun Mishra, Brian Towles, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
>
>
> Bugs: SENTRY-1963
> https://issues.apache.org/jira/browse/SENTRY-1963
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1963: Sentry JSON reporter should use regular implementation for local file system
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java 4063a663c86ea5ed88c40013d5b3550ac0a6272f
>
>
> Diff: https://reviews.apache.org/r/62496/diff/3/
>
>
> Testing
> -------
>
> New unit test written
>
>
> Thanks,
>
> Alexander Kolbasov
>
>