You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/19 13:39:24 UTC
[GitHub] flink pull request #3951: [FLINK-6461] Replace usages of deprecated web port...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3951
[FLINK-6461] Replace usages of deprecated web port key
This is a follow-up to c1025470a91376e251f966fc58cb5cb1c59c7c66; I missed some usages of `ConfigConstants#JOB_MANAGER_WEB_PORT_KEY`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6461_followup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3951.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3951
----
commit d0fb57daaa9c235242fca362eba91b338c1ee4a8
Author: zentol <ch...@apache.org>
Date: 2017-05-19T13:35:26Z
[FLINK-6461] Replace usages of deprecated web port key
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3951: [FLINK-6461] Replace usages of deprecated web port key
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3951
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3951: [FLINK-6461] Replace usages of deprecated web port...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3951
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3951: [FLINK-6461] Replace usages of deprecated web port...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/3951#discussion_r122701964
--- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala ---
@@ -173,7 +173,7 @@ class JobManager(
* to run in the actor system of the associated job manager.
*/
val webMonitorPort : Int = flinkConfiguration.getInteger(
- ConfigConstants.JOB_MANAGER_WEB_PORT_KEY, -1)
+ JobManagerOptions.WEB_PORT.key(), -1)
--- End diff --
I am not sure, but why don't you use `flinkConfiguration.getInteger(JobManagerOptions.WEB_PORT)`? It would have different semantics (it would return `8081` instead of `-1` in case of missing value).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3951: [FLINK-6461] Replace usages of deprecated web port...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3951#discussion_r122706584
--- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala ---
@@ -173,7 +173,7 @@ class JobManager(
* to run in the actor system of the associated job manager.
*/
val webMonitorPort : Int = flinkConfiguration.getInteger(
- ConfigConstants.JOB_MANAGER_WEB_PORT_KEY, -1)
+ JobManagerOptions.WEB_PORT.key(), -1)
--- End diff --
I thought about doing that, but decided against it to preserve existing behavior. If no port is configured at all, with the current code, a random port will be used. Someone out there may be relying on this (although they should just explicitly set it to 0)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---