You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Mithrandir0407 <gi...@git.apache.org> on 2017/04/15 18:27:27 UTC

[GitHub] jmeter pull request #290: Fix some typo in variable name, comments, log and ...

GitHub user Mithrandir0407 opened a pull request:

    https://github.com/apache/jmeter/pull/290

    Fix some typo in variable name, comments, log and properties messages  

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Mithrandir0407/jmeter trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #290
    
----
commit acf3c569bc2a63dd39c86ce2d46a7973cf532cdd
Author: Anass BENOMAR <ab...@umanis.com>
Date:   2017-04-14T17:27:10Z

    Fix Typo

commit a759112e5e7d3295e4054b7a1320fa1302be9e38
Author: Anass BENOMAR <ab...@umanis.com>
Date:   2017-04-15T17:47:46Z

    Fix some typo in comments and log messages

commit 4316d55d4b3ecff2f383ffb40c2882c104a38d6b
Author: Anass BENOMAR <ab...@umanis.com>
Date:   2017-04-15T17:50:05Z

    Clean unused comment

commit 75a0316e7818f2457d442b58caf6dc5ddbaffbf8
Author: Anass BENOMAR <ab...@umanis.com>
Date:   2017-04-15T18:20:23Z

    Fix typo in comments and log messages

commit 7e7d378cb0012ee130f4ebde565f671f69e35fa8
Author: Anass BENOMAR <ab...@umanis.com>
Date:   2017-04-15T18:21:44Z

    Fix typo in constante name

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #290: Fix some typo in variable name, comments, log and propert...

Posted by ljacqu <gi...@git.apache.org>.
Github user ljacqu commented on the issue:

    https://github.com/apache/jmeter/pull/290
  
    +1 for "occurred" and "overridden" but I wouldn't agree that "unRegister" (etc.) is better than "unregister"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #290: Fix some typo in variable name, comments, log and ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/jmeter/pull/290


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---