[GitHub] [zookeeper] symat opened a new pull request #1029: ZOOKEEPER-3455: fix UnifiedServerSocketTest on jdk 13

[GitBox <gi...@apache.org>]

symat opened a new pull request #1029: ZOOKEEPER-3455: fix UnifiedServerSocketTest on jdk 13
URL: https://github.com/apache/zookeeper/pull/1029
 
 
   The `UnifiedServerSocketTest.testConnectWithoutSSLToStrictServer` fails on OpenJDK 13 because in the new default socket implementation (https://openjdk.java.net/jeps/353) the `NioSocketImpl.getInputStream.read()` behaves differently than the old `SocketInputStream.read()`. 
   
   A workaround could be to execute the tests using the `-Djdk.net.usePlainSocketImpl` system property (hardcoding it in the maven / ant configs), which enforces the usage of the old socket implementation in JDK 13. But I preferred instead to make the test compatible with both older and newer JDK, so it should succeed even if someone is executing it outside of our build environment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services