[GitHub] [kylin] shaofengshi commented on issue #768: KYLIN-4106 fix Illegal partition for SelfDefineSortableKey

[GitBox <gi...@apache.org>]

shaofengshi commented on issue #768: KYLIN-4106 fix Illegal partition for SelfDefineSortableKey 
URL: https://github.com/apache/kylin/pull/768#issuecomment-515811619
 
 
   Right, there are some tips with git; Never ruion the master branch with your changes; Always make changes in your branch, and use "master" branch to synch with the remote.
   
   For example:
   
   1) Add the origin git repository as a remote:
   git remote -v
   
   In my case:
   apache	git@github.com:apache/kylin.git (fetch)
   apache	git@github.com:apache/kylin.git (push)
   origin	git@github.com:shaofengshi/kylin.git (fetch)
   origin	git@github.com:shaofengshi/kylin.git (push)
   
   2) to sync other guys change to your local:
   git checkout master
   git fetch apache
   git merge apache
   git push origin
   
   3) if you want to make any change, always in local branch:
   git checkout -b my_changes
   
   after make all changes, push it to remote and then raise the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services