You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/29 17:03:26 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
tillrohrmann opened a new pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965
## What is the purpose of the change
This commit reduces the log noise of the Fabric8FlinkKubeClient by changing the log level
from info to debug.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-579875760
<!--
Meta data
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146635492 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
-->
## CI report:
* b9cfbe9a770e773103b2ff37e4c23731dc54b208 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146635492) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#discussion_r373491974
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -269,14 +271,14 @@ public void eventReceived(Action action, Pod pod) {
callbackHandler.onDeleted(Collections.singletonList(new KubernetesPod(flinkConfig, pod)));
break;
default:
- LOG.info("Skip handling {} event for pod {}", action, pod.getMetadata().getName());
+ LOG.debug("Ignore handling {} event for pod {}", action, pod.getMetadata().getName());
break;
}
}
@Override
public void onClose(KubernetesClientException e) {
- LOG.error("Pods watcher onClose", e);
+ LOG.debug("The pods watcher is closing.", e);
Review comment:
@GJL It is a very nice catch. Currently, i do not think the watcher will be stopped even some exception occurs. Since the default value of `watchReconnectLimit` is -1. That means the `WatchConnectionManager` will always reconnect. The only one case is the `WatchConnectionManager#close()` by expected.
However, if the `watchReconnectLimit` is configured by users via java properties or environment, the watch may be stopped and all the changes will not be processed properly. I will create a new ticket to track this. A fatal exception will be thrown when the watcher is closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10965: [FLINK-15797][k8s]
Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-580346083
Thanks for the review @wangyang0918. Shall we try to use `[k8s]` as the Kubernetes tag? This is much shorter and leaves more characters for the remaining commit header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10965: [FLINK-15797][k8s]
Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-580151148
The changes make sense to me. When the user want to dig into or find the root cause, they could set the log level to `DEBUG`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10965: [FLINK-15797][k8s]
Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-579858757
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b9cfbe9a770e773103b2ff37e4c23731dc54b208 (Wed Jan 29 17:05:19 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10965: [FLINK-15797][k8s]
Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-579858306
cc @wangyang0918
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#discussion_r373087104
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -269,14 +271,14 @@ public void eventReceived(Action action, Pod pod) {
callbackHandler.onDeleted(Collections.singletonList(new KubernetesPod(flinkConfig, pod)));
break;
default:
- LOG.info("Skip handling {} event for pod {}", action, pod.getMetadata().getName());
+ LOG.debug("Ignore handling {} event for pod {}", action, pod.getMetadata().getName());
break;
}
}
@Override
public void onClose(KubernetesClientException e) {
- LOG.error("Pods watcher onClose", e);
+ LOG.debug("The pods watcher is closing.", e);
Review comment:
Maybe @wangyang0918 can tell us why this is ok. If not then this should be properly forwarded and finally handled. This could then be another subtask of https://issues.apache.org/jira/browse/FLINK-15788.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-579875760
<!--
Meta data
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146635492 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
Hash:07bf0c128c1e6f6b47a52791a34439a118fc6f80 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:07bf0c128c1e6f6b47a52791a34439a118fc6f80
-->
## CI report:
* b9cfbe9a770e773103b2ff37e4c23731dc54b208 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146635492) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662)
* 07bf0c128c1e6f6b47a52791a34439a118fc6f80 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#discussion_r373067518
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -269,14 +271,14 @@ public void eventReceived(Action action, Pod pod) {
callbackHandler.onDeleted(Collections.singletonList(new KubernetesPod(flinkConfig, pod)));
break;
default:
- LOG.info("Skip handling {} event for pod {}", action, pod.getMetadata().getName());
+ LOG.debug("Ignore handling {} event for pod {}", action, pod.getMetadata().getName());
break;
}
}
@Override
public void onClose(KubernetesClientException e) {
- LOG.error("Pods watcher onClose", e);
+ LOG.debug("The pods watcher is closing.", e);
Review comment:
Not in the scope of this PR but why is it acceptable to omit error handling? If the connection attempts of the websocket are exhausted, we will stop watching for changes.
https://github.com/fabric8io/kubernetes-client/blob/79c77810d39a277b148d56ab7d1a931b3c373d52/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/WatchConnectionManager.java#L290
https://github.com/fabric8io/kubernetes-client/blob/79c77810d39a277b148d56ab7d1a931b3c373d52/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/WatchConnectionManager.java#L367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#discussion_r373491974
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -269,14 +271,14 @@ public void eventReceived(Action action, Pod pod) {
callbackHandler.onDeleted(Collections.singletonList(new KubernetesPod(flinkConfig, pod)));
break;
default:
- LOG.info("Skip handling {} event for pod {}", action, pod.getMetadata().getName());
+ LOG.debug("Ignore handling {} event for pod {}", action, pod.getMetadata().getName());
break;
}
}
@Override
public void onClose(KubernetesClientException e) {
- LOG.error("Pods watcher onClose", e);
+ LOG.debug("The pods watcher is closing.", e);
Review comment:
@GJL It is a very nice catch. I do not think the watcher will be stopped even some exception occurs. Since the default value of `watchReconnectLimit` is -1. That means the `WatchConnectionManager` will always reconnect. The only one case is the `WatchConnectionManager#close()` by expected.
However, if the `watchReconnectLimit` is configured by users via java properties or environment, the watch may be stopped and all the changes will not be processed properly. I will create a new ticket to track this. A fatal exception will be thrown when the watcher is closed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #10965: [FLINK-15797][k8s]
Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-579875760
<!--
Meta data
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146635492 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
Hash:07bf0c128c1e6f6b47a52791a34439a118fc6f80 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4726 TriggerType:PUSH TriggerID:07bf0c128c1e6f6b47a52791a34439a118fc6f80
Hash:07bf0c128c1e6f6b47a52791a34439a118fc6f80 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146923535 TriggerType:PUSH TriggerID:07bf0c128c1e6f6b47a52791a34439a118fc6f80
-->
## CI report:
* b9cfbe9a770e773103b2ff37e4c23731dc54b208 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146635492) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662)
* 07bf0c128c1e6f6b47a52791a34439a118fc6f80 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146923535) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4726)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 edited a comment on issue #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-580151148
The changes make sense to me. When the user want to dig into or find the root cause, they could set the log level to `DEBUG`.
nit: The commit message need to be updated to `[FLINK-15797][kubernetes]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#discussion_r373514713
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -269,14 +271,14 @@ public void eventReceived(Action action, Pod pod) {
callbackHandler.onDeleted(Collections.singletonList(new KubernetesPod(flinkConfig, pod)));
break;
default:
- LOG.info("Skip handling {} event for pod {}", action, pod.getMetadata().getName());
+ LOG.debug("Ignore handling {} event for pod {}", action, pod.getMetadata().getName());
break;
}
}
@Override
public void onClose(KubernetesClientException e) {
- LOG.error("Pods watcher onClose", e);
+ LOG.debug("The pods watcher is closing.", e);
Review comment:
https://issues.apache.org/jira/browse/FLINK-15836
The ticket has been created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#discussion_r373067518
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -269,14 +271,14 @@ public void eventReceived(Action action, Pod pod) {
callbackHandler.onDeleted(Collections.singletonList(new KubernetesPod(flinkConfig, pod)));
break;
default:
- LOG.info("Skip handling {} event for pod {}", action, pod.getMetadata().getName());
+ LOG.debug("Ignore handling {} event for pod {}", action, pod.getMetadata().getName());
break;
}
}
@Override
public void onClose(KubernetesClientException e) {
- LOG.error("Pods watcher onClose", e);
+ LOG.debug("The pods watcher is closing.", e);
Review comment:
Not in the scope of this PR but why is it acceptable to omit error handling? If the connection attempts of the websocket are exhausted, we will stop watching for changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 edited a comment on issue #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-580151148
The changes make sense to me. When the user want to dig into or find the root cause, they could set the log level to `DEBUG`.
nit: The commit message needs to be updated to `[FLINK-15797][kubernetes]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-579875760
<!--
Meta data
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146635492 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
-->
## CI report:
* b9cfbe9a770e773103b2ff37e4c23731dc54b208 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146635492) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#discussion_r373458622
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
##########
@@ -269,14 +271,14 @@ public void eventReceived(Action action, Pod pod) {
callbackHandler.onDeleted(Collections.singletonList(new KubernetesPod(flinkConfig, pod)));
break;
default:
- LOG.info("Skip handling {} event for pod {}", action, pod.getMetadata().getName());
+ LOG.debug("Ignore handling {} event for pod {}", action, pod.getMetadata().getName());
break;
}
}
@Override
public void onClose(KubernetesClientException e) {
- LOG.error("Pods watcher onClose", e);
+ LOG.debug("The pods watcher is closing.", e);
Review comment:
Then let's leave this statement on ERROR for the time being.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-579875760
<!--
Meta data
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146635492 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
Hash:07bf0c128c1e6f6b47a52791a34439a118fc6f80 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4726 TriggerType:PUSH TriggerID:07bf0c128c1e6f6b47a52791a34439a118fc6f80
Hash:07bf0c128c1e6f6b47a52791a34439a118fc6f80 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146923535 TriggerType:PUSH TriggerID:07bf0c128c1e6f6b47a52791a34439a118fc6f80
-->
## CI report:
* b9cfbe9a770e773103b2ff37e4c23731dc54b208 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146635492) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662)
* 07bf0c128c1e6f6b47a52791a34439a118fc6f80 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146923535) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4726)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10965: [FLINK-15797][k8s]
Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-581402017
Thanks for the review @wangyang0918 and @GJL. Merging this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10965: [FLINK-15797][k8s]
Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-580745007
@tillrohrmann Using the `k8s` instead of `kubernetes` in the commit message is ok for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10965: [FLINK-15797][k8s]
Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-579875760
<!--
Meta data
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
-->
## CI report:
* b9cfbe9a770e773103b2ff37e4c23731dc54b208 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10965:
[FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10965: [FLINK-15797][k8s] Reduce log noise of Fabric8FlinkKubeClient
URL: https://github.com/apache/flink/pull/10965#issuecomment-579875760
<!--
Meta data
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146635492 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
Hash:b9cfbe9a770e773103b2ff37e4c23731dc54b208 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662 TriggerType:PUSH TriggerID:b9cfbe9a770e773103b2ff37e4c23731dc54b208
Hash:07bf0c128c1e6f6b47a52791a34439a118fc6f80 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4726 TriggerType:PUSH TriggerID:07bf0c128c1e6f6b47a52791a34439a118fc6f80
Hash:07bf0c128c1e6f6b47a52791a34439a118fc6f80 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146923535 TriggerType:PUSH TriggerID:07bf0c128c1e6f6b47a52791a34439a118fc6f80
-->
## CI report:
* b9cfbe9a770e773103b2ff37e4c23731dc54b208 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146635492) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4662)
* 07bf0c128c1e6f6b47a52791a34439a118fc6f80 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146923535) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4726)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services