You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "9aman (via GitHub)" <gi...@apache.org> on 2025/07/01 05:59:48 UTC

Re: [PR] Introduce rlsFiltersApplied in the broker response [pinot]

9aman commented on code in PR #16208:
URL: https://github.com/apache/pinot/pull/16208#discussion_r2176496128


##########
pinot-broker/src/main/java/org/apache/pinot/broker/querylog/QueryLogger.java:
##########
@@ -334,6 +334,12 @@ void doFormat(StringBuilder builder, QueryLogger logger, QueryLogParams params)
       void doFormat(StringBuilder builder, QueryLogger logger, QueryLogParams params) {
           builder.append(params._response.getPools());
       }
+    },
+    RLS_FILTERS_APPLIED("rlsFiltersApplied") {
+      @Override
+      void doFormat(StringBuilder builder, QueryLogger logger, QueryLogParams params) {

Review Comment:
   I was not able to find an easy way where we can not log it in case it's disabled. 
   The reason for logging it always is to ensure consistency between broker response and the log. 
   The broker response will always contain this flag (by default false). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org