You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/04 10:26:44 UTC
[GitHub] [hudi] hechao-ustc opened a new pull request, #6582: [DOCS] Add Flink DataStream API demo in Flink Guide.
hechao-ustc opened a new pull request, #6582:
URL: https://github.com/apache/hudi/pull/6582
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hechao-ustc commented on pull request #6582: [DOCS] Add Flink DataStream API demo in Flink Guide.
Posted by GitBox <gi...@apache.org>.
hechao-ustc commented on PR #6582:
URL: https://github.com/apache/hudi/pull/6582#issuecomment-1237581601
I have added the doc，please help me with code review again, thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hechao-ustc commented on pull request #6582: [DOCS] Add Flink DataStream API demo in Flink Guide.
Posted by GitBox <gi...@apache.org>.
hechao-ustc commented on PR #6582:
URL: https://github.com/apache/hudi/pull/6582#issuecomment-1236542371
> Thanks for the contribution @hechao-ustc , i have left one small comment.
@danny0405 hi danny，Thanks for your comment，I have updated the content：
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #6582: [DOCS] Add Flink DataStream API demo in Flink Guide.
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #6582:
URL: https://github.com/apache/hudi/pull/6582#discussion_r962453282
##########
website/versioned_docs/version-0.12.0/flink-quick-start-guide.md:
##########
@@ -74,9 +85,36 @@ export HADOOP_CLASSPATH=`$HADOOP_HOME/bin/hadoop classpath`
Setup table name, base path and operate using SQL for this guide.
The SQL CLI only executes the SQL line by line.
+</TabItem>
+
+<TabItem value="dataStream">
+
+Please add the following dependency to your project:
+```xml
+<dependency>
+ <groupId>org.apache.hudi</groupId>
+ <artifactId>hudi-flink1.13-bundle_2.11</artifactId>
+ <version>0.12.0</version>
Review Comment:
hudi-flink1.13-bundle ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #6582: [DOCS] Add Flink DataStream API demo in Flink Guide.
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6582:
URL: https://github.com/apache/hudi/pull/6582#issuecomment-1236604028
Thanks, can we also add the doc for archived release 0.12.0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #6582: [DOCS] Add Flink DataStream API demo in Flink Guide.
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6582:
URL: https://github.com/apache/hudi/pull/6582#issuecomment-1236515994
Thanks for the contribution @hechao-ustc , i have left one small comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #6582: [DOCS] Add Flink DataStream API demo in Flink Guide.
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #6582:
URL: https://github.com/apache/hudi/pull/6582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org