You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/12 23:57:09 UTC
[GitHub] [flink] xuefuz commented on a change in pull request #8859:
[FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner
xuefuz commented on a change in pull request #8859: [FLINK-12905][table-planner] Enable querying CatalogViews in legacy planner
URL: https://github.com/apache/flink/pull/8859#discussion_r323991807
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -534,6 +535,7 @@ private static CatalogBaseTable instantiateCatalogTable(Table hiveTable, HiveCon
return new CatalogViewImpl(
hiveTable.getViewOriginalText(),
hiveTable.getViewExpandedText(),
+ SqlDialect.HIVE,
Review comment:
View stored in Hive catalog can belong to either Hive Dialect or Flink dialect. This is marked by "is_generic" property. Thus, it's inaccurate to assume "Hive" dialect here. Also, the property and SqlDialect enum has some duplication in meaning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services