[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3263: BP-47 (task6): Direct I/O entrylogger support

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #3263:
URL: https://github.com/apache/bookkeeper/pull/3263#discussion_r867762916


##########
pom.xml:
##########
@@ -905,8 +906,22 @@
           <trimStackTrace>false</trimStackTrace>
           <forkedProcessTimeoutInSeconds>1800</forkedProcessTimeoutInSeconds>
           <rerunFailingTestsCount>${testRetryCount}</rerunFailingTestsCount>
+          <useSystemClassLoader>false</useSystemClassLoader>
+          <argLine>-Djava.library.path=target/natives</argLine>

Review Comment:
   this should be useless, isn't it ?



##########
pom.xml:
##########
@@ -905,8 +906,22 @@
           <trimStackTrace>false</trimStackTrace>
           <forkedProcessTimeoutInSeconds>1800</forkedProcessTimeoutInSeconds>
           <rerunFailingTestsCount>${testRetryCount}</rerunFailingTestsCount>
+          <useSystemClassLoader>false</useSystemClassLoader>
+          <argLine>-Djava.library.path=target/natives</argLine>
         </configuration>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-failsafe-plugin</artifactId>
+        <version>${maven-failsafe-plugin.version}</version>
+        <executions>

Review Comment:
   you don't need to add this "executions" flag, otherwise we are going to execute failsafe every time you run Maven.
   
   it is automatically pre-configured, it makes sense to declare it only in order to set a version



##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java:
##########
@@ -1086,7 +1087,9 @@ EntryLogMetadata extractEntryLogMetadataFromIndex(long entryLogId) throws IOExce
                 bc.read(sizeBuffer.get(), offset);
 
                 int ledgersMapSize = sizeBuffer.get().readInt();
-
+                if (ledgersMapSize <= 0) {

Review Comment:
   why are we adding this check ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org