[jira] [Commented] (STORM-499) Document and clean up shaded dependncy resolution with maven

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159202#comment-14159202 ] 

ASF GitHub Bot commented on STORM-499:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/274


> Document and clean up shaded dependncy resolution with maven
> ------------------------------------------------------------
>
>                 Key: STORM-499
>                 URL: https://issues.apache.org/jira/browse/STORM-499
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.3
>            Reporter: Robert Joseph Evans
>            Assignee: P. Taylor Goetz
>            Priority: Critical
>
> After STORM-447 went in several dependencies have been shaded.  They no longer exist in their normal form on the storm classpath, but the pom.xml that is installed with maven lists them as provided.
> This can become an issue if their topology does not call out dependencies properly and they depend on something like guava, assuming that it will be available from storm.
> from https://github.com/apache/incubator-storm/pull/219  it looks like we should add
> <keepDependenciesWithProvidedScope>false</keepDependenciesWithProvidedScope>
> to help fix this, and add some documentation about how the maven assembly plug-in decides what to pull in, to give users instructions on how to depend on the shaded version of a package if they want to, or to be sure that they are including all of their real dependencies in their pom so in the future when we shade other things they are not caught off guard.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)