[GitHub] [spark] hvanhovell commented on a change in pull request #24189: [SPARK-27253][SQL]SparkSession clone discards SQLConf overrides in favor of SparkConf defaults

[GitBox <gi...@apache.org>]

hvanhovell commented on a change in pull request #24189: [SPARK-27253][SQL]SparkSession clone discards SQLConf overrides in favor of SparkConf defaults
URL: https://github.com/apache/spark/pull/24189#discussion_r268992330
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
 ##########
 @@ -265,7 +265,15 @@ class SparkSession private(
    * implementation is Hive, this will initialize the metastore, which may take some time.
    */
   private[sql] def cloneSession(): SparkSession = {
+    val existingSessionConf = sessionState.conf.getAllConfs
 
 Review comment:
   I just checked, I think we should fix this in `BaseSessionStateBuilder.conf`, we should only copy the SparkConf settings if the `parentState` is None.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org