[GitHub] [spark] dcoliversun commented on pull request #35359: [SPARK-37713][K8S][FOLLOWUP] Fix insufficient namespace propagation

[GitBox <gi...@apache.org>]

dcoliversun commented on pull request #35359:
URL: https://github.com/apache/spark/pull/35359#issuecomment-1024824595


   > Hi, @dcoliversun, @chia7712 , @Yikun , @GabeChurch I don't think that the verbose revert commit and redo commit is necessary. The minimal follow-up PR like this might be enough. On top of this PR, I want to discuss the remaining following missing part. WDYT?
   > 
   > > If configFilesMap have key spark.kubernetes.namespace, which is difference with k8s client config, will throw exception.
   
   @dongjoon-hyun  Thanks for your working.
   If [`SPARK_CONF_DIR` have conf files, and key `spark.kubernetes.namespace` already set in conf files](https://github.com/apache/spark/blob/master/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientUtils.scala#L67), which is difference with k8s client config, k8s client create a configMap with conflict namespace, will throw an exception.
   
   This PR can resolve this problem, update configFileMaps `spark.kubernetes.namespace` through `+` operator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org