[GitHub] [incubator-mxnet] leezu opened a new pull request #16582: [Gluon] Don't serialize shared parameters twice

[GitBox <gi...@apache.org>]

leezu opened a new pull request #16582: [Gluon] Don't serialize shared parameters twice
URL: https://github.com/apache/incubator-mxnet/pull/16582
 
 
   ## Description ##
   `Block.save_parameters` currently stores a separate copy of shared parameters for sub-block which uses the shared parameter. This is wasteful. Instead only store a single copy.
   This change is backwards compatible; all existing valid serialized files continue to work. However, newly serialized files will be smaller in case they contain shared parameters.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [X] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] Don't serialize shared parameters twice in Gluon `Block.save_parameters`
   
   ## Comments ##
   @szha @eric-haibin-lin 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services