You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "justinsiek (via GitHub)" <gi...@apache.org> on 2026/06/08 23:49:54 UTC
[PR] fix(storage): close Files.walk stream in deleteRepo to stop leak [texera]
justinsiek opened a new pull request, #5575:
URL: https://github.com/apache/texera/pull/5575
Closes #5548
Close Files.walk stream so directory handle is released immediately instead of leaking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(storage): close Files.walk stream in deleteRepo to stop leak [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5575:
URL: https://github.com/apache/texera/pull/5575#issuecomment-4654584224
<!-- texera:welcome-first-time-contributor -->
👋 Thanks for your first contribution to Texera, @justinsiek!
You can drive common housekeeping tasks just by leaving a comment. Type the command on its own line.
### On issues
| Command | What it does |
|---|---|
| `/take` | Assign the issue to yourself (self-claim it) |
| `/untake` | Remove yourself as assignee |
To find unclaimed work, search `is:issue is:open no:assignee` — there's no "triage" label; the search filter *is* the triage state.
### Linking sub-issues
| Command | Where to run it | What it does |
|---|---|---|
| `/sub-issue #12 #13` | On the **parent** | Links #12 and #13 as children of this issue |
| `/unsub-issue #12 #13` | On the **parent** | Unlinks those children |
| `/parent-issue #5` | On the **child** | Sets #5 as this issue's parent |
| `/unparent-issue` | On the **child** | Removes this issue's parent (auto-detected) |
| `/unparent-issue #5` | On the **child** | Removes parent #5 explicitly |
You can write references as `#12` or bare `12`. Cross-repo references like `owner/repo#12` aren't supported and are ignored.
### On pull requests (author only)
| Command | What it does |
|---|---|
| `/request-review @user [@user ...]` | Request reviews from those users |
| `/unrequest-review @user [@user ...]` | Cancel those review requests |
You can mention teams as `@org/team`, and `@copilot` works too. Only the PR **author** can use these commands.
> **Note:** Commands must match exactly — `/take this` won't work, only `/take`. Bots are ignored, and you can't self-link an issue or set an issue as its own parent.
For the full contribution flow, see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(storage): close Files.walk stream in deleteRepo to stop leak [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5575:
URL: https://github.com/apache/texera/pull/5575#issuecomment-4664657226
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5575?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 52.18%. Comparing base ([`564ccdb`](https://app.codecov.io/gh/apache/texera/commit/564ccdbfd51089f31dcfdcbdba9f5a872a2f8256?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8ac3d5f`](https://app.codecov.io/gh/apache/texera/commit/8ac3d5fce638ef87c9cc61b64676c6f641c147fa?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5575 +/- ##
=========================================
Coverage 52.17% 52.18%
Complexity 2482 2482
=========================================
Files 1068 1068
Lines 41311 41307 -4
Branches 4439 4439
=========================================
Hits 21556 21556
+ Misses 18490 18486 -4
Partials 1265 1265
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.61% <ø> (ø)` | | Carriedforward from [564ccdb](https://app.codecov.io/gh/apache/texera/commit/564ccdbfd51089f31dcfdcbdba9f5a872a2f8256?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.76% <ø> (ø)` | | Carriedforward from [564ccdb](https://app.codecov.io/gh/apache/texera/commit/564ccdbfd51089f31dcfdcbdba9f5a872a2f8256?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.30% <ø> (+0.01%)` | :arrow_up: | Carriedforward from [564ccdb](https://app.codecov.io/gh/apache/texera/commit/564ccdbfd51089f31dcfdcbdba9f5a872a2f8256?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.65% <ø> (ø)` | | Carriedforward from [564ccdb](https://app.codecov.io/gh/apache/texera/commit/564ccdbfd51089f31dcfdcbdba9f5a872a2f8256?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.06% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.32% <ø> (ø)` | | Carriedforward from [564ccdb](https://app.codecov.io/gh/apache/texera/commit/564ccdbfd51089f31dcfdcbdba9f5a872a2f8256?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `46.42% <ø> (ø)` | | Carriedforward from [564ccdb](https://app.codecov.io/gh/apache/texera/commit/564ccdbfd51089f31dcfdcbdba9f5a872a2f8256?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.72% <ø> (ø)` | | Carriedforward from [564ccdb](https://app.codecov.io/gh/apache/texera/commit/564ccdbfd51089f31dcfdcbdba9f5a872a2f8256?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.75% <ø> (ø)` | | Carriedforward from [564ccdb](https://app.codecov.io/gh/apache/texera/commit/564ccdbfd51089f31dcfdcbdba9f5a872a2f8256?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5575/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.69% <ø> (ø)` | | Carriedforward from [564ccdb](https://app.codecov.io/gh/apache/texera/commit/564ccdbfd51089f31dcfdcbdba9f5a872a2f8256?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5575?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(storage): close Files.walk stream in deleteRepo to stop leak [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #5575:
URL: https://github.com/apache/texera/pull/5575#issuecomment-4665484982
Hi @justinsiek please use our PR template. Please feel free to reopen once it is ready. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(storage): close Files.walk stream in deleteRepo to stop leak [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang closed pull request #5575: fix(storage): close Files.walk stream in deleteRepo to stop leak
URL: https://github.com/apache/texera/pull/5575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org