[GitHub] TisonKun opened a new pull request #7340: [FLINK-11174] [prometheus] Flink Metrics Prometheus label values supp…

[GitBox <gi...@apache.org>]

TisonKun opened a new pull request #7340: [FLINK-11174] [prometheus] Flink Metrics Prometheus label values supp…
URL: https://github.com/apache/flink/pull/7340
 
 
   …ort UTF-8
   
   ## What is the purpose of the change
   
   The original purpose and detail feedback could be found at the corresponding [JIRA](https://issues.apache.org/jira/browse/FLINK-11174).
   
   Briefly, Prometheus follows the standard provided by OpenMetrics, which includes
   
   - Metric names are [a-zA-Z_:][a-zA-Z0-9_:]*
   - Label names are [a-zA-Z0-9_]*
   - Label values are full utf-8, null bytes are permitted
   
   So I tend to release FLINK constraint, make it allowed that label values are utf-8.
   
   ## Brief change log
   
   Do not apply `CHARACTER_FILTER` on label values. It is a direct change.
   
   ## Verifying this change
   
   Manually verifying by the original reporter.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (**no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
     - The serializers: (**no**)
     - The runtime per-record code paths (performance sensitive): (**no**)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper:(**no**)
     - The S3 file system connector:(**no**)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   
   cc @lamber-ken @zentol 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services