You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by zellerh <gi...@git.apache.org> on 2016/03/07 19:28:03 UTC
[GitHub] incubator-trafodion pull request: Fix for a typo in runregr_udr, c...
GitHub user zellerh opened a pull request:
https://github.com/apache/incubator-trafodion/pull/369
Fix for a typo in runregr_udr, causing udr/TEST002 failure
The problem was reported by Eric over the weekend and Arvind found
the bug and suggested this fix.
The failure occurs when a user installed Hadoop using non-standard ports and if there is no running instance on the default ports.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zellerh/incubator-trafodion bug/1581
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/369.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #369
----
commit ea88ae5fd46dd5d9eaa67f8e26330281a1054621
Author: Hans Zeller <hz...@apache.org>
Date: 2016-03-07T18:23:29Z
Fix for a typo in runregr_udr, causing udr/TEST002 failure
The problem was reported by Eric over the weekend and Arvind found
the bug and suggested this fix.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix for a typo in runregr_udr, c...
Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/369#discussion_r55257938
--- Diff: core/sql/regress/tools/runregr_udr.ksh ---
@@ -851,9 +851,9 @@ if [ $LINUX -ne 0 ]; then
fi
--- End diff --
Thanks, now I understand why you are suggesting this. I'll push an update shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix for a typo in runregr_udr, c...
Posted by hegdean <gi...@git.apache.org>.
Github user hegdean commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/369#discussion_r55254497
--- Diff: core/sql/regress/tools/runregr_udr.ksh ---
@@ -851,9 +851,9 @@ if [ $LINUX -ne 0 ]; then
fi
--- End diff --
Do we want to clean up the unused env variables/conditional checks ( _RLD_LIB_PATH and CLASSPATH) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix for a typo in runregr_udr, c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/369
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix for a typo in runregr_udr, c...
Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/369#discussion_r55255398
--- Diff: core/sql/regress/tools/runregr_udr.ksh ---
@@ -851,9 +851,9 @@ if [ $LINUX -ne 0 ]; then
fi
--- End diff --
There is a lot of cleanup that could be done here, but that would require more testing and take more time. Is it ok if we keep this PR to just the typo?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix for a typo in runregr_udr, c...
Posted by hegdean <gi...@git.apache.org>.
Github user hegdean commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/369#discussion_r55256104
--- Diff: core/sql/regress/tools/runregr_udr.ksh ---
@@ -851,9 +851,9 @@ if [ $LINUX -ne 0 ]; then
fi
--- End diff --
Should be fine Hans. Just did not want to see hpt4jdbc.jar being referenced anywhere incorrectly as our tyep4 jar file is now called jdbcT4.jar
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---