[jira] [Commented] (OPENJPA-2671) Wrong type mapping for double in HSQLDB

["Mark Struberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575178#comment-15575178 ] 

Mark Struberg commented on OPENJPA-2671:
----------------------------------------

I think removing the line would fix it. In that case it falls back to the default of DbDictionary, which is "DOUBLE" and should be fine.

> Wrong type mapping for double in HSQLDB
> ---------------------------------------
>
>                 Key: OPENJPA-2671
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2671
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: jdbc
>    Affects Versions: 2.4.1
>            Reporter: Andreas Borg
>
> Currently, Java type {{double}} is mapped to {{NUMERIC}} for HSQLDB:
> {code:title=HSQLDictionary.java, line 82|borderStyle=solid}
>        doubleTypeName = "NUMERIC";
> {code}
> (see https://fisheye6.atlassian.com/browse/~tag=2.4.1/openjpa/tags/2.4.1/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql/HSQLDictionary.java?hb=true).
> This seems wrong to me, as HSQLDB's {{NUMERIC}} is not a binary floating point type, but represents exact decimal numbers and maps to Java type {{BigDecimal}} (see HSQL documentation: http://hsqldb.org/doc/2.0/guide/sqlgeneral-chapt.html#sgc_numeric_types). The corresponding HSQL type for {{double}} is, according to this manual, {{REAL}}, {{FLOAT}} or {{DOUBLE}} (all being equivalent).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)