[GitHub] [flink] zentol commented on a diff in pull request #21201: [FLINK-29807] Drop TypeSerializerConfigSnapshot and savepoint support from Flink versions < 1.8.0

[GitBox <gi...@apache.org>]

zentol commented on code in PR #21201:
URL: https://github.com/apache/flink/pull/21201#discussion_r1012657729


##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/metainfo/StateMetaInfoSnapshotReadersWriters.java:
##########
@@ -123,10 +116,10 @@ private static StateMetaInfoReader getLegacyKeyedStateMetaInfoReader(int readVer
         switch (readVersion) {
             case 1:
             case 2:
-                return LegacyStateMetaInfoReaders.KeyedBackendStateMetaInfoReaderV1V2.INSTANCE;

Review Comment:
   same as below



##########
pom.xml:
##########
@@ -2125,6 +2125,7 @@ under the License.
 								<exclude>@org.apache.flink.annotation.PublicEvolving</exclude>
 								<exclude>@org.apache.flink.annotation.Internal</exclude>
 								<!-- MARKER: start exclusions; these will be wiped by tools/releasing/update_japicmp_configuration.sh -->
+								<exclude>org.apache.flink.streaming.api.datastream.CoGroupedStreams$UnionSerializerConfigSnapshot</exclude>

Review Comment:
   Could you add a comment for why this is in here?



##########
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSerializationUtil.java:
##########
@@ -36,8 +32,6 @@
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.io.InvalidClassException;
-import java.util.ArrayList;
-import java.util.List;

Review Comment:
   Based on the javadocs this entire class should no longer be necessary.



##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/metainfo/StateMetaInfoSnapshotReadersWriters.java:
##########
@@ -139,10 +132,10 @@ private static StateMetaInfoReader getLegacyKeyedStateMetaInfoReader(int readVer
     private static StateMetaInfoReader getLegacyOperatorStateMetaInfoReader(int readVersion) {

Review Comment:
   may as well drop this method, no? It _always_ throws an exception.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org