You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2017/12/14 01:55:26 UTC
Review Request 64590: Stopped logging `operation_id` unconditionally
in agent handler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
Repository: mesos
Description
-------
The `operation_id` is optional, so it should only be logged if it's set.
Diffs
-----
src/slave/slave.cpp e8f7591dc0d57ca8a0eb72f6c1c008d4005a524d
Diff: https://reviews.apache.org/r/64590/diff/1/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 64590: Stopped logging `operation_id`
unconditionally in agent handler.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Dec. 14, 2017, 5:14 a.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Lines 7264-7266 (original), 7264-7266 (patched)
> > <https://reviews.apache.org/r/64590/diff/1/?file=1915797#file1915797line7264>
> >
> > I found it more explicit (the old way) to show that the operation does not have a framework set id.
Yea that's fair. I would be fine with leaving as-is, or doing something like this which is even more explicit. Not worth spending much time on right now:
```
LOG(WARNING)
<< "Dropping status update of offer operation"
<< (update.status().has_operation_id()
? " '" + stringify(update.status().operation_id()) + "'"
: " with no ID")
<< " (operation_uuid: " << operationUUID->toString() << ")"
<< " for framework " << update.framework_id()
<< " because agent is in " << state << " state";
```
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review193768
-----------------------------------------------------------
On Dec. 14, 2017, 1:55 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 1:55 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `operation_id` is optional, so it should only be logged if it's set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e8f7591dc0d57ca8a0eb72f6c1c008d4005a524d
>
>
> Diff: https://reviews.apache.org/r/64590/diff/1/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64590: Stopped logging `operation_id`
unconditionally in agent handler.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review193768
-----------------------------------------------------------
src/slave/slave.cpp
Lines 7264-7266 (original), 7264-7266 (patched)
<https://reviews.apache.org/r/64590/#comment272410>
I found it more explicit (the old way) to show that the operation does not have a framework set id.
- Jie Yu
On Dec. 14, 2017, 1:55 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 1:55 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `operation_id` is optional, so it should only be logged if it's set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e8f7591dc0d57ca8a0eb72f6c1c008d4005a524d
>
>
> Diff: https://reviews.apache.org/r/64590/diff/1/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64590: Stopped logging optional fields
unconditionally in agent handler.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review193862
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64590']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2304 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2326 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2239 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2261 ms total)
[----------] Global test environment tear-down
[==========] 835 tests from 85 test cases ran. (308347 ms total)
[ PASSED ] 825 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending
10 FAILED TESTS
YOU HAVE 205 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590/logs/mesos-tests-stderr.log):
```
I1215 00:07:20.418342 4992 slave.cpp:3401] Shutting down framework c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-0000
I1215 00:07:20.418342 1716 master.cpp:10160] Updating the state of task c82b6c1c-acfd-4f82-a0da-3322d9ab5be1 of framework c8e4e0c9-cc00-40I1215 00:07:19.761358 7208 exec.cpp:162] Version: 1.5.0
I1215 00:07:19.784348 4320 exec.cpp:237] Executor registered on agent c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-S0
I1215 00:07:19.788349 7748 executor.cpp:171] Received SUBSCRIBED event
I1215 00:07:19.792330 7748 executor.cpp:175] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1215 00:07:19.792330 7748 executor.cpp:171] Received LAUNCH event
I1215 00:07:19.796350 7748 executor.cpp:638] Starting task c82b6c1c-acfd-4f82-a0da-3322d9ab5be1
I1215 00:07:19.869345 7748 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1215 00:07:20.394320 7748 executor.cpp:651] Forked command at 8812
I1215 00:07:20.419319 6644 exec.cpp:435] Executor asked to shutdown
I1215 00:07:20.420320 880 executor.cpp:171] Received SHUTDOWN event
I1215 00:07:20.420320 880 executor.cpp:748] Shutting down
I1215 00:07:20.420320 880 executor.cpp:855] Sending SIGTERM to process tree at pid 84f-b6ec-a81d26b237d4-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1215 00:07:20.418342 4992 slave.cpp:6109] Shutting down executor 'c82b6c1c-acfd-4f82-a0da-3322d9ab5be1' of framework c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-0000 at executor(1)@10.3.1.5:53598
I1215 00:07:20.419319 4992 slave.cpp:909] Agent terminating
W1215 00:07:20.419319 4992 slave.cpp:3397] Ignoring shutdown framework c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-0000 because it is terminating
I1215 00:07:20.421320 1716 master.cpp:10266] Removing task c82b6c1c-acfd-4f82-a0da-3322d9ab5be1 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-0000 on agent c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-S0 at slave(327)@10.3.1.5:53577 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 00:07:20.422320 6024 containerizer.cpp:2337] Destroying container 9857200e-9511-49d4-bcde-ce1478b370fb in RUNNING state
I1215 00:07:20.422320 6024 containerizer.cpp:2939] Transitioning the state of container 9857200e-9511-49d4-bcde-ce1478b370fb from RUNNING to DESTROYING
I1215 00:07:20.423318 1716 master.cpp:1305] Agent c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-S0 at slave(327)@10.3.1.5:53577 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1215 00:07:20.423318 1716 master.cpp:3364] Disconnecting agent c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-S0 at slave(327)@10.3.1.5:53577 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 00:07:20.423318 1716 master.cpp:3383] Deactivating agent c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-S0 at slave(327)@10.3.1.5:53577 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 00:07:20.424320 6024 launcher.cpp:156] Asked to destroy container 9857200e-9511-49d4-bcde-ce1478b370fb
I1215 00:07:20.424320 3820 hierarchical.cpp:344] Removed framework c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-0000
I1215 00:07:20.424320 3820 hierarchical.cpp:766] Agent c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-S0 deactivated
I1215 00:07:20.433339 8252 containerizer.cpp:2788] Container 9857200e-9511-49d4-bcde-ce1478b370fb has exited
I1215 00:07:20.461320 444 master.cpp:1147] Master terminating
I1215 00:07:20.463340 3820 hierarchical.cpp:609] Removed agent c8e4e0c9-cc00-404f-b6ec-a81d26b237d4-S0
I1215 00:07:20.751348 4648 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 14, 2017, 10:22 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 10:22 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `operation_id` and `framework_id` fields are optional, so they
> should only be logged if set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 9d0e9debf2ecd142eb6179c12ef4a0ada24b1c6c
>
>
> Diff: https://reviews.apache.org/r/64590/diff/3/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64590: Stopped logging optional fields
unconditionally in agent handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review193824
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.cpp
Lines 7276 (patched)
<https://reviews.apache.org/r/64590/#comment272458>
Nit: could we use operation_uuid here instead? Otherwise it's ambiguous if this UUID is for the status update or the operation.
- Greg Mann
On Dec. 14, 2017, 6:22 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 6:22 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `operation_id` and `framework_id` fields are optional, so they
> should only be logged if set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 9d0e9debf2ecd142eb6179c12ef4a0ada24b1c6c
>
>
> Diff: https://reviews.apache.org/r/64590/diff/3/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64590: Stopped logging optional fields
unconditionally in agent handler.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review193827
-----------------------------------------------------------
FAIL: Mesos tests failed to build.
Reviews applied: `['64590']`
Failed command: `cmake.exe --build . --target mesos-tests --config Debug`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590
Relevant logs:
- [mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590/logs/mesos-tests-build-cmake-stdout.log):
```
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(271): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticatee.cpp(333): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(216): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(242): warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\authentication\cram_md5\authenticator.cpp(274): warning C4267: '=': conversion from 'size_t' to 'unsigned int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\common\protobuf_utils.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\files\files.cpp(704): warning C4267: 'argument': conversion from 'size_t' to 'off_t', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\master.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\quota_handler.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master/master.hpp(2093): warning C4244: 'return': conversion from 'unsigned __int64' to 'double', possible loss of data (compiling source file D:\DCOS\mesos\mesos\src\master\weights_handler.cpp) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(6223): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(6325): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(6890): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\allocator\sorter\drf\sorter.cpp(589): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(9014): warning C4244: 'argument': conversion from 'const ::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\master.cpp(10855): warning C4244: 'return': conversion from '::size_t' to 'double', possible loss of data [D:\DCOS\mesos\src\mesos.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (12) ->
(ClCompile target) ->
D:\DCOS\mesos\mesos\src\slave\slave.cpp(7278): error C2678: binary '<<': no operator found which takes a left-hand operand of type 'const char [16]' (or there is no acceptable conversion) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\slave\slave.cpp(7293): error C2678: binary '<<': no operator found which takes a left-hand operand of type 'const char [16]' (or there is no acceptable conversion) [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\slave\slave.cpp(7284): error C2146: syntax error: missing ';' before identifier 'OfferOperationStatusUpdate' [D:\DCOS\mesos\src\mesos.vcxproj]
135 Warning(s)
3 Error(s)
Time Elapsed 00:03:05.73
```
- [mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590/logs/mesos-tests-CMakeOutput.log):
```
Creating directory "cmTC_1c679.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_1c679.dir\Debug\cmTC_1c679.tlog\".
InitializeBuildStatus:
Creating "cmTC_1c679.dir\Debug\cmTC_1c679.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_1c679.dir\Debug\" /Fd"cmTC_1c679.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 /MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /Fo"cmTC_1c679.dir\Debug\" /Fd"cmTC_1c679.dir\Debug\vc141.pdb" /Gd /TP /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\src.cxx
src.cxx
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_1c679.exe" /INCREMENTAL /NOLOGO kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /PDB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_1c679.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"D:/DCOS/mesos/CMakeFiles/CMakeTmp/Debug/cmTC_1c679.lib" /MACHINE:X64 /machine:x64 cmTC_1c679.dir\Debug\src.obj
cmTC_1c679.vcxproj -> D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\cmTC_1c679.exe
FinalizeBuildStatus:
Deleting file "cmTC_1c679.dir\Debug\cmTC_1c679.tlog\unsuccessfulbuild".
Touching "cmTC_1c679.dir\Debug\cmTC_1c679.tlog\cmTC_1c679.lastbuildstate".
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_1c679.vcxproj" (default targets).
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:00.99
Source file was:
int main() { return 0; }
```
- [mesos-tests-CMakeError.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590/logs/mesos-tests-CMakeError.log):
```
PrepareForBuild:
Creating directory "cmTC_c4d7c.dir\Debug\".
Creating directory "D:\DCOS\mesos\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_c4d7c.dir\Debug\cmTC_c4d7c.tlog\".
InitializeBuildStatus:
Creating "cmTC_c4d7c.dir\Debug\cmTC_c4d7c.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\bin\HostX64\x64\CL.exe /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_c4d7c.dir\Debug\" /Fd"cmTC_c4d7c.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.12.25830.2 for x64
Copyright (C) Microsoft Corporation. All rights reserved.
cl /c /Zi /W3 /WX- /diagnostics:classic /MP /Od /Ob0 /D WIN32 /D _WINDOWS /D UNICODE /D _UNICODE /D "CMAKE_INTDIR=\"Debug\"" /D _UNICODE /D UNICODE /Gm- /RTC1 /MTd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_c4d7c.dir\Debug\" /Fd"cmTC_c4d7c.dir\Debug\vc141.pdb" /Gd /TC /errorReport:queue D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c
CheckIncludeFile.c
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c4d7c.vcxproj]
Done Building Project "D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c4d7c.vcxproj" (default targets) -- FAILED.
Build FAILED.
"D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c4d7c.vcxproj" (default target) (1) ->
(ClCompile target) ->
D:\DCOS\mesos\CMakeFiles\CMakeTmp\CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory [D:\DCOS\mesos\CMakeFiles\CMakeTmp\cmTC_c4d7c.vcxproj]
0 Warning(s)
1 Error(s)
Time Elapsed 00:00:00.57
```
- Mesos Reviewbot Windows
On Dec. 14, 2017, 6:22 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 6:22 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `operation_id` and `framework_id` fields are optional, so they
> should only be logged if set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 9d0e9debf2ecd142eb6179c12ef4a0ada24b1c6c
>
>
> Diff: https://reviews.apache.org/r/64590/diff/2/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64590: Stopped logging optional fields
unconditionally in agent handler.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review194099
-----------------------------------------------------------
PASS: Mesos patch 64590 was successfully built and tested.
Reviews applied: `['64590']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590
- Mesos Reviewbot Windows
On Dec. 18, 2017, 11:24 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2017, 11:24 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `operation_id` and `framework_id` fields are optional, so they
> should only be logged if set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e69d42a2bfae09e2defcd8333c0434a9fd8bac4c
>
>
> Diff: https://reviews.apache.org/r/64590/diff/4/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64590: Stopped logging optional fields
unconditionally in agent handler.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review194648
-----------------------------------------------------------
src/slave/slave.cpp
Lines 7294 (patched)
<https://reviews.apache.org/r/64590/#comment273565>
Since this field name has been changed, we should update this log. But we still want to be sure it's clear that it's the operation's UUID we're logging, not the status's.
Maybe s/operation_uuid/operation uuid/ ?
- Greg Mann
On Dec. 28, 2017, 8:21 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2017, 8:21 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `operation_id` and `framework_id` fields are optional, so they
> should only be logged if set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e0806ab15be3ea790681dc97b20791c8a20512e3
>
>
> Diff: https://reviews.apache.org/r/64590/diff/5/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64590: Stopped logging optional fields
unconditionally in agent handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/
-----------------------------------------------------------
(Updated Dec. 28, 2017, 12:21 p.m.)
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
Changes
-------
Addressed feedback, rebased.
Repository: mesos
Description
-------
The `operation_id` and `framework_id` fields are optional, so they
should only be logged if set.
Diffs (updated)
-----
src/slave/slave.cpp e0806ab15be3ea790681dc97b20791c8a20512e3
Diff: https://reviews.apache.org/r/64590/diff/5/
Changes: https://reviews.apache.org/r/64590/diff/4-5/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 64590: Stopped logging optional fields
unconditionally in agent handler.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review194274
-----------------------------------------------------------
src/slave/slave.cpp
Line 7428 (original), 7439 (patched)
<https://reviews.apache.org/r/64590/#comment272999>
Don't we need to check `operation->info().has_id()` here?
- Chun-Hung Hsiao
On Dec. 18, 2017, 11:24 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2017, 11:24 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `operation_id` and `framework_id` fields are optional, so they
> should only be logged if set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e69d42a2bfae09e2defcd8333c0434a9fd8bac4c
>
>
> Diff: https://reviews.apache.org/r/64590/diff/4/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 64590: Stopped logging optional fields
unconditionally in agent handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/
-----------------------------------------------------------
(Updated Dec. 18, 2017, 3:24 p.m.)
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
Changes
-------
Addressed feedback.
Repository: mesos
Description
-------
The `operation_id` and `framework_id` fields are optional, so they
should only be logged if set.
Diffs (updated)
-----
src/slave/slave.cpp e69d42a2bfae09e2defcd8333c0434a9fd8bac4c
Diff: https://reviews.apache.org/r/64590/diff/4/
Changes: https://reviews.apache.org/r/64590/diff/3-4/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 64590: Stopped logging optional fields
unconditionally in agent handler.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/
-----------------------------------------------------------
(Updated Dec. 14, 2017, 10:22 a.m.)
Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
Changes
-------
Rebased & addressed feedback.
Summary (updated)
-----------------
Stopped logging optional fields unconditionally in agent handler.
Repository: mesos
Description (updated)
-------
The `operation_id` and `framework_id` fields are optional, so they
should only be logged if set.
Diffs (updated)
-----
src/slave/slave.cpp 9d0e9debf2ecd142eb6179c12ef4a0ada24b1c6c
Diff: https://reviews.apache.org/r/64590/diff/2/
Changes: https://reviews.apache.org/r/64590/diff/1-2/
Testing
-------
`make check` on GNU/Linux
Thanks,
Gaston Kleiman
Re: Review Request 64590: Stopped logging `operation_id`
unconditionally in agent handler.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review193788
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64590']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590/logs/mesos-tests-stdout.log):
```
[ RUN ] SlaveTest.RunTaskGroupFailedSecretGeneration
[ OK ] SlaveTest.RunTaskGroupFailedSecretGeneration (245 ms)
[ RUN ] SlaveTest.RunTaskGroupInvalidExecutorSecret
[ OK ] SlaveTest.RunTaskGroupInvalidExecutorSecret (234 ms)
[ RUN ] SlaveTest.RunTaskGroupReferenceTypeSecret
[ OK ] SlaveTest.RunTaskGroupReferenceTypeSecret (228 ms)
[ RUN ] SlaveTest.RunTaskGroupGenerateSecretAfterShutdown
[ OK ] SlaveTest.RunTaskGroupGenerateSecretAfterShutdown (252 ms)
[ RUN ] SlaveTest.KillTaskGroupBetweenRunTaskParts
[ OK ] SlaveTest.KillTaskGroupBetweenRunTaskParts (215 ms)
[ RUN ] SlaveTest.KillQueuedTaskGroup
[ OK ] SlaveTest.KillQueuedTaskGroup (284 ms)
[ RUN ] SlaveTest.MaxCompletedExecutorsPerFrameworkFlag
[ OK ] SlaveTest.MaxCompletedExecutorsPerFrameworkFlag (1039 ms)
[ RUN ] SlaveTest.ShutdownV0ExecutorIfItReregistersWithoutReconnect
[ OK ] SlaveTest.ShutdownV0ExecutorIfItReregistersWithoutReconnect (256 ms)
[ RUN ] SlaveTest.IgnoreV0ExecutorIfItReregistersWithoutReconnect
[ OK ] SlaveTest.IgnoreV0ExecutorIfItReregistersWithoutReconnect (259 ms)
[ RUN ] SlaveTest.BrowseExecutorSandboxByVirtualPath
[ OK ] SlaveTest.BrowseExecutorSandboxByVirtualPath (314 ms)
[ RUN ] SlaveTest.DisconnectedExecutorDropsMessages
[ OK ] SlaveTest.DisconnectedExecutorDropsMessages (313 ms)
[ RUN ] SlaveTest.ResourceProviderSubscribe
[ OK ] SlaveTest.ResourceProviderSubscribe (230 ms)
[ RUN ] SlaveTest.ResourceVersions
[ OK ] SlaveTest.ResourceVersions (184 ms)
[ RUN ] SlaveTest.ReconfigurationPolicy
[ OK ] SlaveTest.ReconfigurationPolicy (292 ms)
[ RUN ] SlaveTest.ResourceProviderReconciliation
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64590/logs/mesos-tests-stderr.log):
```
@ 00007FF7B79AA290 google::LogMessage::SendToLog
@ 00007FF7B79A9A77 google::LogMessage::Flush
@ 00007FF7B79AB5B1 google::LogMessageFatal::~LogMessageFatal
@ 00007FF7B58C2B0A mesos::internal::slave::Slave::handleResourceProviderMessage
@ 00007FF7B5A6DDE5 ??
@ 00007FF7B595B4C8 std::_Invoker_functor::_Call<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,process::ProcessBase * __ptr64>
@ 00007FF7B59E11B8 std::invoke<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,process::ProcessBase * __ptr64>
@ 00007FF7B59F13BB lambda::internal::Partial<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,std::_Ph<1> >::invoke_expand<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,std::tuple<process::Future<mesos::internal::ResourceProvi
@ 00007FF7B593771A )<process::ProcessBase * __ptr64
@ 00007FF7B5961B1C std::_Invoker_functor::_Call<lambda::internal::Partial<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,std::_Ph<1> >,process::ProcessBase * __ptr64>
@ 00007FF7B59E761C std::invoke<lambda::internal::Partial<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,std::_Ph<1> >,process::ProcessBase * __ptr64>
@ 00007FF7B593F681 )<lambda::internal::Partial<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,std::_Ph<1> >,process::ProcessBase * __ptr64
@ 00007FF7B5A7BD06 process::ProcessBase * __ptr64)>::CallableFn<lambda::internal::Partial<<lambda_2c5dd0fb32c5d47ebd14bcab173f55d7>,process::Future<mesos::internal::ResourceProviderMessage>,std::_Ph<1> > >::operator(
@ 00007FF7B7499CCD process::ProcessBase * __ptr64)>::operator(
@ 00007FF7B7372DA9 process::ProcessBase::consume
@ 00007FF7B74EDE2A process::DispatchEvent::consume
@ 00007FF7B39343D7 process::ProcessBase::serve
@ 00007FF7B7380A8B process::ProcessManager::resume
@ 00007FF7B748A4F1 ??
@ 00007FF7B73C8FD0 std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF7B741E970 std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF7B73D7D8C std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Execute<0>
@ 00007FF7B74D5E2A std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Run
@ 00007FF7B74C28B8 std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Go
@ 00007FF7B74AA59D std::_Pad::_Call_func
@ 00007FF7B864C358 invoke_thread_procedure
@ 00007FF7B864BE01 __cdecl*)(void * __ptr64)
@ 00007FFB34601FE4 BaseThreadInitThunk
@ 00007FFB3532EF91 RtlUserThreadStart
```
- Mesos Reviewbot Windows
On Dec. 14, 2017, 9:55 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 9:55 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `operation_id` is optional, so it should only be logged if it's set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e8f7591dc0d57ca8a0eb72f6c1c008d4005a524d
>
>
> Diff: https://reviews.apache.org/r/64590/diff/1/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>