You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "srijeet0406 (via GitHub)" <gi...@apache.org> on 2023/02/17 04:21:46 UTC
[GitHub] [trafficcontrol] srijeet0406 opened a new pull request, #7355: Adding Types table and details
srijeet0406 opened a new pull request, #7355:
URL: https://github.com/apache/trafficcontrol/pull/7355
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR is not related to any issue. It adds the Types table and details views to Traffic Portal V2.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Portal
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
Make sure all the unit/ e2e tests pass.
Manual testing:
Run TPV2
Go to the Types page
Make sure everything looks good
Make sure all the right click functionality works
Verify that all the CRUD functionality works for Types
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
- master
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7355: Adding Types table and details
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on code in PR #7355:
URL: https://github.com/apache/trafficcontrol/pull/7355#discussion_r1112274957
##########
experimental/traffic-portal/nightwatch/globals/globals.ts:
##########
@@ -54,9 +54,12 @@ import {
RequestCacheGroup,
ResponseCacheGroup,
ResponsePhysicalLocation,
- RequestPhysicalLocation
+ RequestPhysicalLocation, RequestType
Review Comment:
this should be on its own line, in keeping with the way the rest of this statement is organized
##########
experimental/traffic-portal/src/app/core/types/detail/type-detail.component.html:
##########
@@ -0,0 +1,49 @@
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+<mat-card>
+ <tp-loading *ngIf="!type"></tp-loading>
+ <form ngNativeValidate (ngSubmit)="submit($event)" *ngIf="type">
+ <mat-card-content>
+ <mat-form-field *ngIf="!new">
+ <mat-label>ID</mat-label>
+ <input matInput type="text" name="id" disabled readonly [defaultValue]="type.id" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Name</mat-label>
+ <input matInput type="text" name="name" required [(ngModel)]="type.name" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Description</mat-label>
+ <input matInput type="text" name="description" required [(ngModel)]="type.description" />
+ </mat-form-field>
+ <mat-form-field *ngIf="!new">
+ <mat-label>Use In Table</mat-label>
+ <input matInput type="text" name="useInTable" disabled readonly [(ngModel)]="type.useInTable" />
+ </mat-form-field>
+ <mat-form-field *ngIf="new">
+ <mat-label>Use In Table</mat-label>
+ <input matInput type="text" name="useInTable" disabled readonly value="server" />
+ </mat-form-field>
Review Comment:
Looking below, it seems like you are setting `useInTable` immediately on new Types, so yeah that can just be `type.useInTable`.
##########
experimental/traffic-portal/src/app/api/type.service.ts:
##########
@@ -79,6 +79,37 @@ export class TypeService extends APIService {
return this.getTypesInTable("server");
}
+ /**
+ * Deletes an existing type.
+ *
+ * @param id ID of the type to delete.
+ * @returns The deleted type.
+ */
+ public async deleteType(id: number): Promise<TypeFromResponse> {
Review Comment:
Ideally anywhere you can pass the ID, you should also be able to pass the response form of the object (i.e. `TypeFromResponse` in this case).
##########
experimental/traffic-portal/src/app/core/types/detail/type-detail.component.html:
##########
@@ -0,0 +1,49 @@
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+<mat-card>
+ <tp-loading *ngIf="!type"></tp-loading>
+ <form ngNativeValidate (ngSubmit)="submit($event)" *ngIf="type">
+ <mat-card-content>
+ <mat-form-field *ngIf="!new">
+ <mat-label>ID</mat-label>
+ <input matInput type="text" name="id" disabled readonly [defaultValue]="type.id" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Name</mat-label>
+ <input matInput type="text" name="name" required [(ngModel)]="type.name" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Description</mat-label>
+ <input matInput type="text" name="description" required [(ngModel)]="type.description" />
+ </mat-form-field>
+ <mat-form-field *ngIf="!new">
+ <mat-label>Use In Table</mat-label>
+ <input matInput type="text" name="useInTable" disabled readonly [(ngModel)]="type.useInTable" />
Review Comment:
2-way binding is unnecessary when the control is read-only; this should probably use `defaultValue` just like the ID field.
##########
experimental/traffic-portal/src/app/core/types/detail/type-detail.component.html:
##########
@@ -0,0 +1,49 @@
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+
+<mat-card>
+ <tp-loading *ngIf="!type"></tp-loading>
+ <form ngNativeValidate (ngSubmit)="submit($event)" *ngIf="type">
+ <mat-card-content>
+ <mat-form-field *ngIf="!new">
+ <mat-label>ID</mat-label>
+ <input matInput type="text" name="id" disabled readonly [defaultValue]="type.id" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Name</mat-label>
+ <input matInput type="text" name="name" required [(ngModel)]="type.name" />
+ </mat-form-field>
+ <mat-form-field>
+ <mat-label>Description</mat-label>
+ <input matInput type="text" name="description" required [(ngModel)]="type.description" />
+ </mat-form-field>
+ <mat-form-field *ngIf="!new">
+ <mat-label>Use In Table</mat-label>
+ <input matInput type="text" name="useInTable" disabled readonly [(ngModel)]="type.useInTable" />
+ </mat-form-field>
+ <mat-form-field *ngIf="new">
+ <mat-label>Use In Table</mat-label>
+ <input matInput type="text" name="useInTable" disabled readonly value="server" />
+ </mat-form-field>
Review Comment:
It seems like the only difference between these two is the value, and thus they can be combined into one like
```html
<mat-form-field>
<mat-label>Use In Table</mat-label>
<input matInput type="text" name="useInTable" disabled readonly [defaultValue]="new ? 'server' : type.useInTable" />
</mat-form-field>
```
Although, what would be even better is to reduce `new ? 'server' : type.useInTable` to just `type.useInTable`, and set the `useInTable` property of new Types to `"server"` immediately within the controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #7355: Adding Types table and details
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 merged PR #7355:
URL: https://github.com/apache/trafficcontrol/pull/7355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org