Re: [PR] feat: Allow datafusion-ffi to opt out of proto parquet [datafusion]

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #22951:
URL: https://github.com/apache/datafusion/pull/22951#discussion_r3519814608


##########
datafusion/ffi/src/session/mod.rs:
##########
@@ -504,6 +509,15 @@ fn table_options_from_rhashmap(options: SVec<(SString, SString)>) -> TableOption
                 .unwrap_or_else(|err| log::warn!("Error parsing table options: {err}"));
         }
     }
+    #[cfg(not(feature = "parquet"))]
+    for (key, value) in options.iter().filter_map(|(k, v)| {
+        let (prefix, key) = k.split_once(".")?;
+        (prefix == "parquet").then(|| (key, v))
+    }) {
+        table_options.parquet.set(key, value).unwrap_or_else(|err| {
+            log::warn!("Error parsing parquet table option: {err}")
+        });
+    }

Review Comment:
   Thanks for the review. That makes sense. I have removed, PTAL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org