You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/27 09:04:04 UTC
[GitHub] [rocketmq] coder-zzzz opened a new issue #3805: Broker stat getTotalTps
coder-zzzz opened a new issue #3805:
URL: https://github.com/apache/rocketmq/issues/3805
The getTotalTps return the broker's pull request count in broker stat command . Why not return the broker's pull message count?
When call DefaultMessageStore's getMessage method , at the end of method, totalCount will increase 1 no matter how many messages is found.
```java
if (GetMessageStatus.FOUND == status) {
this.storeStatsService.getGetMessageTimesTotalFound().add(1);
} else {
this.storeStatsService.getGetMessageTimesTotalMiss().add(1);
}
```
I wonder if it can change to message count , or add a new response param to show message pull trend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] caigy commented on issue #3805: Broker stat getTotalTps
Posted by GitBox <gi...@apache.org>.
caigy commented on issue #3805:
URL: https://github.com/apache/rocketmq/issues/3805#issuecomment-1023825419
`getTotalTps` indicates how busy the broker serves the pull request, which is based on **request**, and it is different from the number of messages found, which is based on **response**. So I think they are two different metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Kvicii commented on issue #3805: Broker stat getTotalTps
Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #3805:
URL: https://github.com/apache/rocketmq/issues/3805#issuecomment-1023203610
@coder-zzzz I think it should be counted as an optimization.this should be correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on issue #3805: Broker stat getTotalTps
Posted by GitBox <gi...@apache.org>.
cserwen commented on issue #3805:
URL: https://github.com/apache/rocketmq/issues/3805#issuecomment-1036059906
I think you are talking about this metric:`BROKER_GET_NUMS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coder-zzzz commented on issue #3805: Broker stat getTotalTps
Posted by GitBox <gi...@apache.org>.
coder-zzzz commented on issue #3805:
URL: https://github.com/apache/rocketmq/issues/3805#issuecomment-1023829868
@Kvicii @caigy add a new metric maybe a good choice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coder-zzzz closed issue #3805: Broker stat getTotalTps
Posted by GitBox <gi...@apache.org>.
coder-zzzz closed issue #3805:
URL: https://github.com/apache/rocketmq/issues/3805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Kvicii commented on issue #3805: Broker stat getTotalTps
Posted by GitBox <gi...@apache.org>.
Kvicii commented on issue #3805:
URL: https://github.com/apache/rocketmq/issues/3805#issuecomment-1023836171
@coder-zzzz
If this metric is really needed, I think it's up to vote, if it's just a small change, it counts as an optimization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coder-zzzz commented on issue #3805: Broker stat getTotalTps
Posted by GitBox <gi...@apache.org>.
coder-zzzz commented on issue #3805:
URL: https://github.com/apache/rocketmq/issues/3805#issuecomment-1038790016
> BROKER_GET_NUMS
you are right! Tks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org