You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liyinan926 <gi...@git.apache.org> on 2018/08/01 16:32:17 UTC

[GitHub] spark pull request #21884: [SPARK-24960][K8S] explicitly expose ports on dri...

Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21884#discussion_r206948155
  
    --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStepSuite.scala ---
    @@ -203,4 +212,12 @@ class BasicDriverFeatureStepSuite extends SparkFunSuite {
           "spark.files" -> "https://localhost:9000/file1.txt,/opt/spark/file2.txt")
         assert(additionalProperties === expectedSparkConf)
       }
    +
    +  def containerPort(name: String, portNumber: Int): ContainerPort = {
    +    val port = new ContainerPort()
    +    port.setName(name)
    --- End diff --
    
    Looks like the indention here is incorrect.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org