[jira] [Created] (TEZ-3969) TaskAttemptImpl: static fields initialized in instance ctor

["Gopal V (JIRA)" <ji...@apache.org>]

Gopal V created TEZ-3969:
----------------------------

             Summary: TaskAttemptImpl: static fields initialized in instance ctor
                 Key: TEZ-3969
                 URL: https://issues.apache.org/jira/browse/TEZ-3969
             Project: Apache Tez
          Issue Type: Bug
            Reporter: Gopal V


The TODO is probably well-placed (& the bug looks somewhat intentional to minimize the size of TaskAttemptImpl object).

This isn't causing any bugs at the moment, because the block is called from the same thread always.

{code}
public TaskAttemptImpl(TezTaskAttemptID attemptId, EventHandler eventHandler,
 ...
    // TODO: Move these configs over to Vertex.VertexConfig
    MAX_ALLOWED_OUTPUT_FAILURES = conf.getInt(TezConfiguration
        .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES, TezConfiguration
        .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_DEFAULT);

    MAX_ALLOWED_OUTPUT_FAILURES_FRACTION = conf.getDouble(TezConfiguration
        .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_FRACTION, TezConfiguration
        .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_FRACTION_DEFAULT);
    
    MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC = conf.getInt(
        TezConfiguration.TEZ_AM_MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC,
        TezConfiguration.TEZ_AM_MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC_DEFAULT);
{code}

But these fields are static members of the class & this is excluded in the findbugs to avoid warnings.

{code}
  private static double MAX_ALLOWED_OUTPUT_FAILURES_FRACTION;
  private static int MAX_ALLOWED_OUTPUT_FAILURES;
  private static int MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC;
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)