You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/05 10:17:43 UTC

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #17209: [feature][client-cpp] Support inclusive seek for cpp client

Demogorgon314 commented on code in PR #17209:
URL: https://github.com/apache/pulsar/pull/17209#discussion_r962742630


##########
pulsar-client-cpp/python/pulsar_test.py:
##########
@@ -543,7 +543,7 @@ def test_reader_on_specific_message(self):
         # The reset would be effectively done on the next position relative to reset.

Review Comment:
   Actually, the previous seek behavior is wrong, the previous implementation of seek is always inclusive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org