[GitHub] [couchdb] jjrodrig opened a new pull request #2464: Port etags tests into elixir test suite

[GitBox <gi...@apache.org>]

jjrodrig opened a new pull request #2464: Port etags tests into elixir test suite
URL: https://github.com/apache/couchdb/pull/2464
 
 
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   This PR ports etags_head test into exlixir test suite. I've checked the etags_views.js but it currently disabled in the js test suite so I have not included it int to port.
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   ```
   make elixir tests=test/elixir/test/etags_head.exs
   ```
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [X] Code is written and works correctly
   - [X] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] nickva closed pull request #2464: Port etags tests into elixir test suite

[GitBox <gi...@apache.org>]

nickva closed pull request #2464: Port etags tests into elixir test suite
URL: https://github.com/apache/couchdb/pull/2464
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] nickva commented on issue #2464: Port etags tests into elixir test suite

[GitBox <gi...@apache.org>]

nickva commented on issue #2464: Port etags tests into elixir test suite
URL: https://github.com/apache/couchdb/pull/2464#issuecomment-575841827
 
 
   @jjrodrig thank you for your contribution
   
   Test looks good. I added two small fixes to it:
   
   ```
   diff --git a/test/elixir/lib/couch.ex b/test/elixir/lib/couch.ex
   index 994b68173..3aef07f01 100644
   --- a/test/elixir/lib/couch.ex
   +++ b/test/elixir/lib/couch.ex
   @@ -110,7 +110,7 @@ defmodule Couch do
        end
      end
   
   -  def process_response_body(headers, body) when body == [] do
   +  def process_response_body(_headers, body) when body == [] do
        ""
      end
   
   diff --git a/test/javascript/tests/etags_head.js b/test/javascript/tests/etags_head.js
   index 9faca4af6..6cb99e40d 100644
   --- a/test/javascript/tests/etags_head.js
   +++ b/test/javascript/tests/etags_head.js
   @@ -11,6 +11,7 @@
    // the License.
   
    couchTests.etags_head = function(debug) {
   +  return console.log('done in tests=test/elixir/test/etags_head_test.exs');
      var db_name = get_random_db_name();
      var db = new CouchDB(db_name, {"X-Couch-Full-Commit":"false"});
      db.createDb();
   ```
   
   Then squashed them into one commit and pushed them to the new PR https://github.com/apache/couchdb/pull/2469
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services