[Bug 123412] New: GluePoint EscapeDirections get lost at save/reload

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=123412

            Bug ID: 123412
        Issue Type: DEFECT
           Summary: GluePoint EscapeDirections get lost at save/reload
           Product: Impress
           Version: 4.0.1
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: P3
         Component: editing
          Assignee: issues@openoffice.apache.org
          Reporter: Armin.Le.Grand@me.com
                CC: issues@openoffice.apache.org

ALG: GluePoints have EscapeDirections; these are editable in the UI and are
or-ed together from left/right/top/bottom to define all allowed escape
directions for a connector using the gluepoint. This gets lost when:

- new draw
- add rectangle
- activate gluepoint mode (ckick on the 'tube' icon in the drawing toolbar, the
gluepoint toolbar appears)
- add new gluepoint
- select 'exit direction left' and 'exit direction top'
- save
- reload
- select object
- activate gluepoint mode
- select GluePoint
-> exit direction left' and 'exit direction top' are lost

This happens because there is a basic msiunderstanding error in the UNO API for
this; the com::sun::star::drawing::EscapeDirection only supports single
directions, not a combination of those, except 'HORIZONTAL' and 'VERTICAL'. As
a result this is also handled wrong in ODF im/export.

This means:
- the com::sun::star::drawing::EscapeDirection definition has to be changed
- its usage in com::sun::star::drawing::GluePoint2 has to be adapted
- the UNO API implementation has to be adapted
- the ODF im/export has to be adapted

Since the 1st two points mean an incompatible UNO API change, probably
EscapeDirection2 and GluePoint3 definitions would be needed. Since the exchange
of these data is using a type-free container::XIndexContainer and
container::XIdentifierContainer API it is not clear how this can be done
compatible at all.

If someone knows, please add advice to this task.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123412] GluePoint EscapeDirections get lost at save/reload

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=123412

--- Comment #4 from Regina Henschel <rb...@t-online.de> ---
Please look at bug 114567. That is the issue about changing ODF. Adding a
dependence?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123412] GluePoint EscapeDirections get lost at save/reload

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=123412

--- Comment #3 from Armin Le Grand <Ar...@me.com> ---
ALG: Hi Regina, unfortunately it's not an error in the UI. The core and UI
exist much longer than the API and ODF, thus I guess the person doing the API
and ODF for it just did not know what the core can do here.
Of course you are right that it is also possible to fix the UI, but why should
we limit us to hor/ver and four directions? There are useful cases, e.g. a
user-defined gluepoint near the upper left corner of a shape, there you want
connectors to go left or up, nothing else.
A fix is not urgent, there is no real request (noone complained so far). I just
stumbled over it and wanted to have a reminder, hence the task.
If you want a suggestion to the TC should look like other values where or-ed
values make sense. Interestingly this is the case in Gluepoint but not in
Gluepoint2 in the UNO API. This may be a hint that someone did this even by
purpose because MS formats do only use these limited values? I have no idea
yet, I tried to find in various PPT versions a possibbility to edit gluepoints
at all, but could not find it anywhere. If you know better, please feel free to
add infos here.
Thus: No panic, just a reminder...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123412] GluePoint EscapeDirections get lost at save/reload

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=123412

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
                   |g                           |

--- Comment #1 from Armin Le Grand <Ar...@me.com> ---
ALG: Grepping to keep an eye on it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

[Bug 123412] GluePoint EscapeDirections get lost at save/reload

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=123412

Armin Le Grand <Ar...@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
ALG: Aha, exists. Setting to duplicate.

*** This bug has been marked as a duplicate of bug 114567 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

[Bug 123412] GluePoint EscapeDirections get lost at save/reload

[bu...@apache.org]

https://issues.apache.org/ooo/show_bug.cgi?id=123412

Regina Henschel <rb...@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rb.henschel@t-online.de

--- Comment #2 from Regina Henschel <rb...@t-online.de> ---
Hi Armin, I think, that the error is in the UI. The escape directions cannot be
combined in ODF1.2. There exist: auto, up, right, down, left, horizontal,
vertical. 'horizontal' has the meaning of 'left or right', and 'vertical' has
the meaning of 'up or down'.
Therefore a combination 'up or left' cannot be written to ODF1.2. Indeed in
such cases no draw:escape-direction is written at all.

That was already the same way in .sxd format.

So the API is correct. But the UI has to be changed, so that it only allows
settings, which can be stored. For example handle it the same as alignment. One
icon for "auto" ("smart" in API). If it is set, then the others are disabled.
And six buttons for the others, where only exact one can be set.

The ODF attribute has strings as values. Allowing to combine them would result
in a very long list of valid strings or a change of the value type to a string
list or to a bit field. That would require a suggestion to the TC.

Exist user requests for such combining of escape directions?

Is this feature needed for import of Microsoft formats?

[SVG connector does not yet exist, but is still an early draft.]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.