You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/19 12:44:49 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2343: serial: Prevent RX stall

xiaoxiang781216 commented on a change in pull request #2343:
URL: https://github.com/apache/incubator-nuttx/pull/2343#discussion_r526851860



##########
File path: drivers/serial/serial.c
##########
@@ -924,6 +924,20 @@ static ssize_t uart_read(FAR struct file *filep, FAR char *buffer, size_t buflen
               /* Re-enable UART Rx interrupts */
 
               uart_enablerxint(dev);
+
+              /* Check again if the RX buffer is empty.  The UART driver

Review comment:
       but line 922 already disable CPU receiving any interrupt before enable rx irq. I am curious why the irq can still dispatch to your interrupt handler.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org