You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/05/17 01:46:08 UTC

[kudu-CR] [java-client] clear non-covered entries from meta cache on table open (second try) 

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/6909

to review the following change.

Change subject: [java-client] clear non-covered entries from meta cache on table open (second try)
......................................................................

[java-client] clear non-covered entries from meta cache on table open (second try)

This is a followup to d07ecd6ded01201c9. I missed a place in the open
table flow where we retry opening if the table has non-running tablets.
This was revealed when the test accompanying that commit was flaky about
20% of the time.

Change-Id: I8dbd16b2179b1d72b635a4dfaf54928d62125607
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/6909/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dbd16b2179b1d72b635a4dfaf54928d62125607
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] [java-client] clear non-covered entries from meta cache on table open (second try)

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: [java-client] clear non-covered entries from meta cache on table open (second try)
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbd16b2179b1d72b635a4dfaf54928d62125607
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] [java-client] clear non-covered entries from meta cache on table open (second try)

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: [java-client] clear non-covered entries from meta cache on table open (second try)
......................................................................


[java-client] clear non-covered entries from meta cache on table open (second try)

This is a followup to d07ecd6ded01201c9. I missed a place in the open
table flow where we retry opening if the table has non-running tablets.
This was revealed when the test accompanying that commit was flaky about
20% of the time.

Change-Id: I8dbd16b2179b1d72b635a4dfaf54928d62125607
Reviewed-on: http://gerrit.cloudera.org:8080/6909
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8dbd16b2179b1d72b635a4dfaf54928d62125607
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>