You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/02/08 05:25:00 UTC

[jira] [Work logged] (HADOOP-16767) S3AInputStream reopening does not handle non IO exceptions properly

     [ https://issues.apache.org/jira/browse/HADOOP-16767?focusedWorklogId=549396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-549396 ]

ASF GitHub Bot logged work on HADOOP-16767:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Feb/21 05:24
            Start Date: 08/Feb/21 05:24
    Worklog Time Spent: 10m 
      Work Description: yzhangal opened a new pull request #2685:
URL: https://github.com/apache/hadoop/pull/2685


   Contributed by Sergei Poganshev.
   
   Catches Exception instead of IOException in closeStream() 
   and so handle exceptions such as SdkClientException by 
   aborting the wrapped stream. This will increase resilience
   to failures, as any which occuring during stream closure
   will be caught. Furthermore, because the
   underlying HTTP connection is aborted, rather than closed,
   it will not be recycled to cause problems on subsequent
   operations.
   
   ## NOTICE
   
   Please create an issue in ASF JIRA before opening a pull request,
   and you need to set the title of the pull request which starts with
   the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
   For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 549396)
    Remaining Estimate: 0h
            Time Spent: 10m

> S3AInputStream reopening does not handle non IO exceptions properly
> -------------------------------------------------------------------
>
>                 Key: HADOOP-16767
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16767
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 3.1.1
>            Reporter: Sergei Poganshev
>            Assignee: Sergei Poganshev
>            Priority: Major
>             Fix For: 3.3.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Since only {{IOException}} is getting caught in [closeStream|https://github.com/apache/hadoop/blob/24080666e5e2214d4a362c889cd9aa617be5de81/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L579], {{reopen()}} fails in case {{SdkClientException}} occurs on a drain attempt. This leads to multiple failing retries of {{invoker.retry("read",...)}} and then the whole {{read()}} operation failing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org